Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 219773004: DevTools: hide autocomplete when the autocompletion prefix is empty (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: hide autocomplete when the autocompletion prefix is empty This patch hides autocomplete suggestion box in editor whenever autocopmletion prefix length is zero. BUG=358255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
Please take a look
6 years, 8 months ago (2014-03-31 18:09:40 UTC) #1
apavlov
lgtm
6 years, 8 months ago (2014-04-01 11:59:16 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 13:42:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/219773004/1
6 years, 8 months ago (2014-04-01 13:42:45 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 14:54:48 UTC) #5
Message was sent while issue was closed.
Change committed as 170573

Powered by Google App Engine
This is Rietveld 408576698