MD Settings: Fix canceling of "Add site exception" dialog.

MD Settings: Fix canceling of "Add site exception" dialog.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a33b37e0660858abe81a8bc60dddffe512e18109
Cr-Commit-Position: refs/heads/master@{#408829}

[dpapad, 2016-07-29 21:47:31]

Description was changed from

==========
MD Settings: Fix canceling of "Add site exception" dialog.

BUG=625332
==========

to

==========
MD Settings: Fix canceling of "Add site exception" dialog.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-29 21:48:02]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 21:48:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-29 21:49:42]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-07-29 21:49:42]

Missed this occurrence of dialog-dismiss during the initial migration CL.

[Dan Beam, 2016-07-29 21:55:40]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-29 21:55:41]

lgtm

did we reallly grep for all of these this time?

https://codereview.chromium.org/2197723003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.html
(right):

https://codereview.chromium.org/2197723003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.html:25:
$i18n{cancel}
indent off

[dpapad, 2016-07-29 22:02:11]

Yes, I grepped for dialog-confirm and dialog-dismiss.
There are some occurrences in chrome/browser/resources/ (but not under
settings/). I verified that remaining occurrences are still using paper-dialog.

https://codereview.chromium.org/2197723003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.html
(right):

https://codereview.chromium.org/2197723003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.html:25:
$i18n{cancel}
On 2016/07/29 at 21:55:41, Dan Beam wrote:
> indent off

Done.

[dschuyler, 2016-07-29 23:17:52]

lgtm

[dpapad, 2016-07-29 23:59:21]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-07-29 23:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2197723003/#ps20001
(title: "Nit.")

[commit-bot: I haz the power, 2016-07-29 23:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:11:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 01:13:41]

Description was changed from

==========
MD Settings: Fix canceling of "Add site exception" dialog.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix canceling of "Add site exception" dialog.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a33b37e0660858abe81a8bc60dddffe512e18109
Cr-Commit-Position: refs/heads/master@{#408829}
==========

[commit-bot: I haz the power, 2016-07-30 01:13:42]

Patchset 2 (id:??) landed as
https://crrev.com/a33b37e0660858abe81a8bc60dddffe512e18109
Cr-Commit-Position: refs/heads/master@{#408829}