Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197653005: Increase test runtime timeout configuration for hot_reload tests in debug mode as we are about to a… (Closed)

Created:
4 years, 4 months ago by siva
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase test runtime timeout configuration for hot_reload tests in debug mode as we are about to add additional verification which involves iterating over the heap. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a794b54273fb58ae1de70cf5b1ce9e88da273c8a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tools/testing/dart/runtime_configuration.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 4 months ago (2016-07-29 23:28:30 UTC) #2
rmacnak
lgtm
4 years, 4 months ago (2016-07-29 23:41:18 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/2197653005/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/2197653005/diff/1/tools/testing/dart/test_options.dart#newcode828 tools/testing/dart/test_options.dart:828: isReload: configuration['hot_reload'], With John's change, || configuration['hot_reload_rollback']
4 years, 4 months ago (2016-08-01 17:51:03 UTC) #4
siva
https://chromiumcodereview.appspot.com/2197653005/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/2197653005/diff/1/tools/testing/dart/test_options.dart#newcode828 tools/testing/dart/test_options.dart:828: isReload: configuration['hot_reload'], On 2016/08/01 17:51:03, rmacnak wrote: > With ...
4 years, 4 months ago (2016-08-01 21:33:18 UTC) #5
siva
4 years, 4 months ago (2016-08-01 21:37:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a794b54273fb58ae1de70cf5b1ce9e88da273c8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698