Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2197653004: DevTools: do not apply number editings shortcuts to HTML attributes which look like URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
index f00de1e730c3a007edf88f74aad57414255d5341..012aef4dc7d9f749c94e86daaae28169e4788dfb 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
@@ -678,7 +678,9 @@ WebInspector.ElementsTreeElement.prototype = {
WebInspector.handleElementValueModifications(event, attribute);
return "";
}
- config.setPostKeydownFinishHandler(postKeyDownFinishHandler);
+
+ if (!(new WebInspector.ParsedURL(attributeValueElement.textContent).isValid))
dgozman 2016/07/29 23:12:38 if (!attributeValueElement.textContent.asParsedURL
lushnikov 2016/07/29 23:29:41 sweet 8) thanks!
+ config.setPostKeydownFinishHandler(postKeyDownFinishHandler);
this._editing = WebInspector.InplaceEditor.startEditing(attribute, config);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698