Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2197643002: perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. (Closed)

Created:
4 years, 4 months ago by jcgregorio
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002 Committed: https://skia.googlesource.com/skia/+/01f696e30f775e345d1e378b2c40dd24e3a037c3

Patch Set 1 #

Total comments: 3

Patch Set 2 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M infra/bots/recipe_modules/skia/resources/upload_bench_results.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jcgregorio
4 years, 4 months ago (2016-07-29 15:25:21 UTC) #3
borenet
Needs expectations update whenever you get it working. https://codereview.chromium.org/2197643002/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2197643002/diff/1/infra/bots/recipes/swarm_trigger.py#newcode412 infra/bots/recipes/swarm_trigger.py:412: 'gsutil', ...
4 years, 4 months ago (2016-07-29 15:34:55 UTC) #4
borenet
Also, we'll need to make sure Perf is polling both old and new buckets for ...
4 years, 4 months ago (2016-07-29 15:35:30 UTC) #5
jcgregorio
On 2016/07/29 at 15:35:30, borenet wrote: > Also, we'll need to make sure Perf is ...
4 years, 4 months ago (2016-07-29 16:41:43 UTC) #6
jcgregorio
https://codereview.chromium.org/2197643002/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2197643002/diff/1/infra/bots/recipes/swarm_trigger.py#newcode422 infra/bots/recipes/swarm_trigger.py:422: # env=api.skia.gsutil_env('chromium-skia-gm.boto'), On 2016/07/29 at 15:34:55, borenet wrote: > ...
4 years, 4 months ago (2016-07-29 16:41:58 UTC) #7
borenet
LGTM
4 years, 4 months ago (2016-07-29 16:48:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197643002/20001
4 years, 4 months ago (2016-07-29 17:09:41 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:54:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/01f696e30f775e345d1e378b2c40dd24e3a037c3

Powered by Google App Engine
This is Rietveld 408576698