Issue 219763003: reland "make bots call android_ninja instead of android_make"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219763003: reland "make bots call android_ninja instead of android_make" (Closed)

Created:
6 years, 8 months ago by epoger

Modified:
6 years, 8 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/buildbot.git@master

Visibility:
Public.

More Reviews

Description

reland "make bots call android_ninja instead of android_make" BUG=skia:2338 Committed: https://skia.googlesource.com/buildbot/+/73a028bfb6a2e5ef1300728dbaf660af688138b2

Patch Set 1 : exactly as committed previously #

Patch Set 2 : fixes #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	slave/skia_slave_scripts/build_step.py	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

See fixes in patchset 2. I ran this on some test buildbots locally, and it ...

6 years, 8 months ago (2014-03-31 19:30:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/219763003/20001

6 years, 8 months ago (2014-03-31 20:10:55 UTC) #4

commit-bot: I haz the power

Change committed as 73a028bfb6a2e5ef1300728dbaf660af688138b2

6 years, 8 months ago (2014-03-31 20:11:02 UTC) #5

epoger

6 years, 8 months ago (2014-03-31 20:16:49 UTC) #6

Message was sent while issue was closed.

Seems to be faring much better than last time.

First Android builder to pick it up was
http://108.170.220.76:10117/builders/Build-Ubuntu12-GCC-Arm7-Release-NvidiaLo...

Expand Messages | Collapse Messages