Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: services/ui/common/gpu_service.cc

Issue 2197613003: gpu: Introduce GpuChannelEstablishFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/common/gpu_service.cc
diff --git a/services/ui/common/gpu_service.cc b/services/ui/common/gpu_service.cc
index 9a2f4c561a3e4b28576250d2b1782b026dcdc69e..113d08682570ce0ae112e5e54271b36302a3be8e 100644
--- a/services/ui/common/gpu_service.cc
+++ b/services/ui/common/gpu_service.cc
@@ -22,8 +22,10 @@ namespace {
void PostTask(scoped_refptr<base::SingleThreadTaskRunner> runner,
const tracked_objects::Location& from_here,
- const base::Closure& callback) {
- runner->PostTask(from_here, callback);
+ const gpu::GpuChannelEstablishedCallback& callback,
+ scoped_refptr<gpu::GpuChannelHost> established_channel_host) {
+ runner->PostTask(from_here,
+ base::Bind(callback, std::move(established_channel_host)));
}
GpuService* g_gpu_service = nullptr;
@@ -67,11 +69,13 @@ GpuService* GpuService::GetInstance() {
return g_gpu_service;
}
-void GpuService::EstablishGpuChannel(const base::Closure& callback) {
+void GpuService::EstablishGpuChannel(
+ const gpu::GpuChannelEstablishedCallback& callback) {
base::AutoLock auto_lock(lock_);
auto runner = base::ThreadTaskRunnerHandle::Get();
- if (GetGpuChannelLocked()) {
- runner->PostTask(FROM_HERE, callback);
+ scoped_refptr<gpu::GpuChannelHost> channel = GetGpuChannelLocked();
+ if (channel) {
+ PostTask(runner, FROM_HERE, callback, std::move(channel));
return;
}
establish_callbacks_.push_back(
@@ -109,11 +113,6 @@ scoped_refptr<gpu::GpuChannelHost> GpuService::EstablishGpuChannelSync() {
return gpu_channel_;
}
-scoped_refptr<gpu::GpuChannelHost> GpuService::GetGpuChannel() {
- base::AutoLock auto_lock(lock_);
- return GetGpuChannelLocked();
-}
-
scoped_refptr<gpu::GpuChannelHost> GpuService::GetGpuChannelLocked() {
if (gpu_channel_ && gpu_channel_->IsLost()) {
main_task_runner_->PostTask(
@@ -203,7 +202,7 @@ void GpuService::EstablishGpuChannelOnMainThreadDone(
gpu_service_.reset();
for (const auto& i : establish_callbacks_)
- i.Run();
+ i.Run(gpu_channel_);
establish_callbacks_.clear();
}

Powered by Google App Engine
This is Rietveld 408576698