Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2197603002: Make instrumented_libraries download script src-independent (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make instrumented_libraries download script src-independent This allows to call this script as a hook from other projects than chromium, e.g. v8. BUG=chromium:631979 Committed: https://crrev.com/0cfebcd743295079c9ce4f00af8cafc5a7fa1b56 Cr-Commit-Position: refs/heads/master@{#408623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/instrumented_libraries/scripts/download_binaries.py View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-07-29 12:18:42 UTC) #4
Michael Achenbach
The trybot error doesn't really seem to come from this change. The script was already ...
4 years, 4 months ago (2016-07-29 12:25:44 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-29 12:36:36 UTC) #6
Alexander Potapenko
lgtm
4 years, 4 months ago (2016-07-29 12:39:39 UTC) #7
Alexander Potapenko
lgtm lgtm
4 years, 4 months ago (2016-07-29 12:39:40 UTC) #8
Michael Achenbach
FYI: Same bot from a whitespace CL: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_msan_rel_ng/builds/414
4 years, 4 months ago (2016-07-29 12:43:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197603002/1
4 years, 4 months ago (2016-07-29 12:44:01 UTC) #11
Michael Achenbach
Filed http://crbug.com/632702
4 years, 4 months ago (2016-07-29 12:46:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 13:14:39 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 13:16:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfebcd743295079c9ce4f00af8cafc5a7fa1b56
Cr-Commit-Position: refs/heads/master@{#408623}

Powered by Google App Engine
This is Rietveld 408576698