Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2197593002: [test] Make the meaning of some options clearer in --help. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make the meaning of some options clearer in --help. NOTRY=true Committed: https://crrev.com/f1c32c82c5a1ccef8a20f5d4367d2a2a807b1c50 Cr-Commit-Position: refs/heads/master@{#38178}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use consistent string quotes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/run-tests.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bgeron
PTAL.
4 years, 4 months ago (2016-07-29 11:23:02 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/2197593002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2197593002/diff/1/tools/run-tests.py#newcode294 tools/run-tests.py:294: " default: \"%s\"" % ','.join(VARIANTS)) nit: Use "," ...
4 years, 4 months ago (2016-07-29 11:50:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197593002/20001
4 years, 4 months ago (2016-07-29 11:57:08 UTC) #7
bgeron
Thanks, landing. On 2016/07/29 11:50:25, Michael Achenbach (slow) wrote: > lgtm > > https://codereview.chromium.org/2197593002/diff/1/tools/run-tests.py > ...
4 years, 4 months ago (2016-07-29 11:57:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 11:58:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 12:01:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1c32c82c5a1ccef8a20f5d4367d2a2a807b1c50
Cr-Commit-Position: refs/heads/master@{#38178}

Powered by Google App Engine
This is Rietveld 408576698