Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2197583002: Revert of [heap] Give marking functions for incremental marking more precise names. (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Give marking functions for incremental marking more precise names. (patchset #3 id:40001 of https://codereview.chromium.org/2173773002/ ) Reason for revert: Breaks Roll https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271267/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/MaterialHistoryBrowserTest.DrawerTest Original issue's description: > [heap] Give marking functions for incremental marking more precise names. > > BUG= > > Committed: https://crrev.com/4ac08c97f0c26cca3c0687b7349c929a4db2df43 > Cr-Commit-Position: refs/heads/master@{#38141} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/91612668faf6b0f863fe44827afed59cbf2a0e52 Cr-Commit-Position: refs/heads/master@{#38175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M src/heap/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 6 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [heap] Give marking functions for incremental marking more precise names.
4 years, 4 months ago (2016-07-29 11:02:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197583002/1
4 years, 4 months ago (2016-07-29 11:02:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 11:02:24 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 11:04:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91612668faf6b0f863fe44827afed59cbf2a0e52
Cr-Commit-Position: refs/heads/master@{#38175}

Powered by Google App Engine
This is Rietveld 408576698