Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per DougArnett Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index c757702b01bace4e290c725600225bb70b7e3e28..152834214fca260c329cacbecbde39550ade4801 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -50,6 +50,11 @@ class RequestCoordinator : public KeyedService {
bool SavePageLater(
const GURL& url, const ClientId& client_id, bool user_reqeusted);
+ // Cancel a list of requests by |client_id|. This removes requests from the
dougarnett 2016/08/01 18:28:35 Remove ...
Pete Williamson 2016/08/01 23:23:07 Done.
+ // request queue, but does not cancel an in-progress pre-render.
+ // TODO(petewil): Add code to cancel an in-progress pre-render.
+ void RemoveRequests(const std::vector<ClientId>& client_ids);
Dmitry Titov 2016/08/01 19:37:29 Can we add a callback? It's an async operation, an
Pete Williamson 2016/08/01 23:23:07 As we discussed offline, we are providing an obser
+
// Starts processing of one or more queued save page later requests.
// Returns whether processing was started and that caller should expect
// a callback. If processing was already active, returns false.

Powered by Google App Engine
This is Rietveld 408576698