Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment changes per feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_unittest.cc
diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
index 875bfb2d5908cc22d01a3424e5588d7e8fb49078..cba4f10082ccc2b8b15db89b5db305e16dd0f59a 100644
--- a/components/offline_pages/background/request_queue_unittest.cc
+++ b/components/offline_pages/background/request_queue_unittest.cc
@@ -175,6 +175,43 @@ TEST_F(RequestQueueTest, RemoveRequest) {
ASSERT_EQ(0ul, last_requests().size());
}
+TEST_F(RequestQueueTest, RemoveRequestByClientId) {
+ base::Time creation_time = base::Time::Now();
+ // Put two requests on the queue with different client IDs.
+ SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
+ kUserRequested);
+ queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
+ base::Unretained(this)));
+ SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time,
+ kUserRequested);
+ queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
+ base::Unretained(this)));
+ PumpLoop();
+
+ queue()->GetRequests(
+ base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
+ ASSERT_EQ(2ul, last_requests().size());
+
+ std::vector<ClientId> client_ids;
+ client_ids.push_back(kClientId);
+
+ // Removing the first client ID should leave only the second on the queue.
+ queue()->RemoveRequestsByClientId(
+ client_ids,
+ base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
+
+ queue()->GetRequests(
+ base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
+ ASSERT_EQ(1ul, last_requests().size());
+ ASSERT_EQ(kClientId2, last_requests().front().client_id());
+}
+
// A longer test populating the request queue with more than one item, properly
// listing multiple items and removing the right item.
TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) {
« no previous file with comments | « components/offline_pages/background/request_queue_store_unittest.cc ('k') | components/offline_pages/offline_page_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698