components/offline_pages/background/request_queue_store_sql.h - Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_store_sql.h

Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment changes per feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue_store.h ('k') | components/offline_pages/background/request_queue_store_sql.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_store_sql.h

diff --git a/components/offline_pages/background/request_queue_store_sql.h b/components/offline_pages/background/request_queue_store_sql.h

index 92dd09f45c66d5adf50992f519c34d7962cb52ab..18f6e8792d85715384c7291adfc60cf67944d2db 100644

--- a/components/offline_pages/background/request_queue_store_sql.h

+++ b/components/offline_pages/background/request_queue_store_sql.h

@@ -38,6 +38,8 @@ class RequestQueueStoreSQL : public RequestQueueStore {

const UpdateCallback& callback) override;

void RemoveRequests(const std::vector<int64_t>& request_ids,

const RemoveCallback& callback) override;

+ void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,

+ const RemoveCallback& callback) override;

void Reset(const ResetCallback& callback) override;

private:

@@ -59,6 +61,11 @@ class RequestQueueStoreSQL : public RequestQueueStore {

scoped_refptr<base::SingleThreadTaskRunner> runner,

const std::vector<int64_t>& request_ids,

const RemoveCallback& callback);

+ static void RemoveRequestsByClientIdSync(

+ sql::Connection* db,

+ scoped_refptr<base::SingleThreadTaskRunner> runner,

+ const std::vector<ClientId>& client_ids,

+ const RemoveCallback& callback);

static void ResetSync(sql::Connection* db,

const base::FilePath& db_file_path,

scoped_refptr<base::SingleThreadTaskRunner> runner,