Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index c757702b01bace4e290c725600225bb70b7e3e28..2588345c8e773f3c2ac63c3370216e310e38f080 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -50,6 +50,10 @@ class RequestCoordinator : public KeyedService {
bool SavePageLater(
const GURL& url, const ClientId& client_id, bool user_reqeusted);
+ // Cancel a list of requests by |client_id|. This removes requests from the
+ // request queue, but does not cancel an in-progress pre-render.
dougarnett 2016/07/29 19:01:23 interesting question about how to deal with a pend
Pete Williamson 2016/07/29 22:48:52 Per offline discussion, let's leave this as is, an
+ void CancelRequests(const std::vector<ClientId>& client_ids);
dougarnett 2016/07/29 19:01:24 RemoveRequests more accurate since removed request
Pete Williamson 2016/07/29 22:48:52 Done.
+
// Starts processing of one or more queued save page later requests.
// Returns whether processing was started and that caller should expect
// a callback. If processing was already active, returns false.
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698