Provide API in RequestCoordinator to remove results by client ID.

components/offline_pages/background/request_queue_store.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_H_
 
 #include <stdint.h>
 #include <vector>
 
 #include "base/callback.h"
+#include "components/offline_pages/offline_page_item.h"
 
 namespace offline_pages {
 
 class SavePageRequest;
 
 // Interface for classes storing save page requests.
 class RequestQueueStore {
  public:
   enum class UpdateStatus {
     ADDED,    // Request was added successfully.
@@ skipping 19 matching lines @@
   // Asynchronously adds or updates request in store.
   // Result of the update is passed in the callback.
   virtual void AddOrUpdateRequest(const SavePageRequest& request,
                                   const UpdateCallback& callback) = 0;
 
   // Asynchronously removes requests from the store using their IDs.
   // Result of the update, and a number of removed pages is passed in the
   // callback.
   // Result of remove should be false, when one of the provided items couldn't
   // be deleted, e.g. because it was missing.
   virtual void RemoveRequests(const std::vector<int64_t>& request_ids,

[fgorski, 2016/08/02 05:01:22]

thought: should we rename this to  RemoveRequestByRequestId?
WDYT?

[Pete Williamson, 2016/08/02 23:27:17]

I think it is not being used, and I should just remove it in a follow on checkin
(there is already a TODO to do this.).  Since I'm removing it, it doesn't seem
worthwhile to rename it.

[fgorski, 2016/08/03 03:29:41]

Acknowledged.

                               const RemoveCallback& callback) = 0;
 
+  // Asynchronously removes requests from the store using their ClientIds.
+  // Result of the update, and a number of removed pages is passed in the
+  // callback.  Result of remove should be false, when one of the provided items
+  // couldn't be deleted, e.g. because it was missing. In case client_ids is
+  // empty, though this will return true, but the count of deleted pages will be
+  // 0.
+  virtual void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,
+                                        const RemoveCallback& callback) = 0;
+
   // Resets the store.
   virtual void Reset(const ResetCallback& callback) = 0;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_H_