Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: components/tracing/core/scattered_stream_writer_unittest.cc

Issue 2197563002: tracing v2: minor refactoring to TraceRingBuffer test helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simpler check Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/core/scattered_stream_writer.h ('k') | components/tracing/core/trace_ring_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/core/scattered_stream_writer_unittest.cc
diff --git a/components/tracing/core/scattered_stream_writer_unittest.cc b/components/tracing/core/scattered_stream_writer_unittest.cc
index 0ce182411d893b5f831740af22ef01acc1687754..424aa0013d5a85f7a1477441f9eab8aaf893d5bd 100644
--- a/components/tracing/core/scattered_stream_writer_unittest.cc
+++ b/components/tracing/core/scattered_stream_writer_unittest.cc
@@ -68,8 +68,13 @@ TEST(ScatteredStreamWriterTest, ScatteredWrites) {
for (uint8_t i = 0; i < 5; ++i)
ssw.WriteByte(0xFF);
memcpy(ssw.ReserveBytes(4).begin, kFourByteBuf, sizeof(kFourByteBuf));
- EXPECT_EQ(7u, delegate.chunks().size());
- EXPECT_EQ(4u, ssw.bytes_available());
+ memcpy(ssw.ReserveBytesUnsafe(3), kThreeByteBuf, sizeof(kThreeByteBuf));
+ memcpy(ssw.ReserveBytes(3).begin, kThreeByteBuf, sizeof(kThreeByteBuf));
+ memcpy(ssw.ReserveBytesUnsafe(1), kOneByteBuf, sizeof(kOneByteBuf));
+ memcpy(ssw.ReserveBytes(1).begin, kOneByteBuf, sizeof(kOneByteBuf));
+
+ EXPECT_EQ(8u, delegate.chunks().size());
+ EXPECT_EQ(3u, ssw.bytes_available());
EXPECT_EQ("0001020304050607", delegate.GetChunkAsString(0));
EXPECT_EQ("4060616263FF5051", delegate.GetChunkAsString(1));
@@ -77,7 +82,8 @@ TEST(ScatteredStreamWriterTest, ScatteredWrites) {
EXPECT_EQ("A3A4A5A6A7A8A9AA", delegate.GetChunkAsString(3));
EXPECT_EQ("ABACADAEAFB0B1B2", delegate.GetChunkAsString(4));
EXPECT_EQ("B3FFFFFFFFFF0000", delegate.GetChunkAsString(5));
- EXPECT_EQ("6061626300000000", delegate.GetChunkAsString(6));
+ EXPECT_EQ("6061626350515200", delegate.GetChunkAsString(6));
+ EXPECT_EQ("5051524040000000", delegate.GetChunkAsString(7));
// Finally reset the writer to a new buffer.
uint8_t other_buffer[8] = {0};
« no previous file with comments | « components/tracing/core/scattered_stream_writer.h ('k') | components/tracing/core/trace_ring_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698