Quick fix: nullify Isolate in background parsing slightly later.

Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612
Committed: https://crrev.com/8558cbe557c5cd5f8a284743f8db48668afc4266
Cr-Commit-Position: refs/heads/master@{#38167}

[marja, 2016-07-29 08:56:37]

marja@chromium.org changed reviewers:
+ jochen@chromium.org

[marja, 2016-07-29 08:56:38]

.

[marja, 2016-07-29 08:57:13]

... I'll investigate separately how come no test broken when I landed the
previous version; we certainly exercise that code path in tests.

[jochen (gone - plz use gerrit), 2016-07-29 08:58:04]

why not create the parser on the foreground thread in the ctor of the background
parsing task?

[marja, 2016-07-29 09:00:26]

Because of the stack limit, which we can set correctly only when we're in the
background thread.

The real fix would be to transmit set_allow_tailcalls somehow differently.

[marja, 2016-07-29 09:18:38]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 09:18:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-29 09:19:39]

lgtm

[marja, 2016-07-29 09:22:44]

The CQ bit was unchecked by marja@chromium.org

[marja, 2016-07-29 09:22:51]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-29 09:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-07-29 09:22:57]

The CQ bit was unchecked by marja@chromium.org

[marja, 2016-07-29 09:23:10]

Description was changed from

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=
==========

to

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612
==========

[marja, 2016-07-29 09:23:16]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-29 09:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 09:40:44]

Description was changed from

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612
==========

to

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612
==========

[commit-bot: I haz the power, 2016-07-29 09:40:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 09:41:30]

Description was changed from

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612
==========

to

==========
Quick fix: nullify Isolate in background parsing slightly later.

Parser ctor reads information from it.

BUG=632612

Committed: https://crrev.com/8558cbe557c5cd5f8a284743f8db48668afc4266
Cr-Commit-Position: refs/heads/master@{#38167}
==========

[commit-bot: I haz the power, 2016-07-29 09:41:31]

Patchset 2 (id:??) landed as
https://crrev.com/8558cbe557c5cd5f8a284743f8db48668afc4266
Cr-Commit-Position: refs/heads/master@{#38167}