Refactor fxge/fx_apple and fx_win header files

Refactor fxge/fx_apple and fx_win header files

- Renamed header for CFX_QuartzDevice class
- Removed unused class CFX_WinBitmapDevice
- Split remaining fx_ge_win32 header

Committed: https://pdfium.googlesource.com/pdfium/+/7484762421e85aa5d610f47aa547470786eecab8

[npm, 2016-07-29 20:29:57]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 20:30:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 20:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:31:20]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/1485)

[npm, 2016-07-29 20:31:49]

Description was changed from

==========
Refactor fxge/fx_apple and fx_win header files
Renamed header for CFX_QuartzDevice class
Split fx_ge_win32 header, and removed unused class in it
==========

to

==========
Refactor fxge/fx_apple and fx_win header files
Renamed header for CFX_QuartzDevice class
Removed unused class CFX_WinBitmapDevice
Split remaining fx_ge_win32 header
==========

[npm, 2016-07-29 20:31:49]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-07-29 20:36:34]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 20:36:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 20:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:43:09]

Dry run: Try jobs failed on following builders:
  win_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_rel_gyp...)

[npm, 2016-07-29 20:51:27]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 20:51:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-07-29 20:59:46]

The CQ bit was unchecked by npm@chromium.org

[npm, 2016-07-29 21:02:43]

PTAL

[Lei Zhang, 2016-07-29 21:11:59]

Description was changed from

==========
Refactor fxge/fx_apple and fx_win header files
Renamed header for CFX_QuartzDevice class
Removed unused class CFX_WinBitmapDevice
Split remaining fx_ge_win32 header
==========

to

==========
Refactor fxge/fx_apple and fx_win header files

- Renamed header for CFX_QuartzDevice class
- Removed unused class CFX_WinBitmapDevice
- Split remaining fx_ge_win32 header
==========

[Lei Zhang, 2016-07-29 21:12:28]

Just some nits. I edited the CL description too...

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
File core/fxge/include/cfx_windowsdevice.h (right):

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
core/fxge/include/cfx_windowsdevice.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
2016 since this is a "new" file?

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
core/fxge/include/cfx_windowsdevice.h:37: #endif
Which #if does this match with? Add a comment.

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/win32/cfx_win...
File core/fxge/win32/cfx_windowsdib.h (right):

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/win32/cfx_win...
core/fxge/win32/cfx_windowsdib.h:50: #endif
Ditto

[npm_g, 2016-07-29 21:26:07]

npm@google.com changed reviewers:
+ npm@google.com

[npm_g, 2016-07-29 21:26:07]

Addressed comments

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
File core/fxge/include/cfx_windowsdevice.h (right):

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
core/fxge/include/cfx_windowsdevice.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
On 2016/07/29 21:12:27, Lei Zhang wrote:
> 2016 since this is a "new" file?

Done.

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/include/cfx_w...
core/fxge/include/cfx_windowsdevice.h:37: #endif
On 2016/07/29 21:12:27, Lei Zhang wrote:
> Which #if does this match with? Add a comment.

Done.

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/win32/cfx_win...
File core/fxge/win32/cfx_windowsdib.h (right):

https://codereview.chromium.org/2197513004/diff/40001/core/fxge/win32/cfx_win...
core/fxge/win32/cfx_windowsdib.h:50: #endif
On 2016/07/29 21:12:27, Lei Zhang wrote:
> Ditto

Done.

[Lei Zhang, 2016-07-29 21:54:48]

lgtm

[npm_g, 2016-07-29 21:55:19]

The CQ bit was checked by npm@google.com

[commit-bot: I haz the power, 2016-07-29 21:55:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm_g, 2016-07-29 21:55:59]

The CQ bit was unchecked by npm@google.com

[npm, 2016-07-29 21:56:52]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:57:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 22:20:29]

Description was changed from

==========
Refactor fxge/fx_apple and fx_win header files

- Renamed header for CFX_QuartzDevice class
- Removed unused class CFX_WinBitmapDevice
- Split remaining fx_ge_win32 header
==========

to

==========
Refactor fxge/fx_apple and fx_win header files

- Renamed header for CFX_QuartzDevice class
- Removed unused class CFX_WinBitmapDevice
- Split remaining fx_ge_win32 header

Committed:
https://pdfium.googlesource.com/pdfium/+/7484762421e85aa5d610f47aa547470786ee...
==========

[commit-bot: I haz the power, 2016-07-29 22:20:30]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/7484762421e85aa5d610f47aa547470786ee...