|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by lazyboy Modified:
4 years, 4 months ago Reviewers:
asargent_no_longer_on_chrome CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[UserScript] Do not create SubstitutionMap if not necessary.
Tiny improvement.
We won't need to call GetLocalizationMessages for most extensions as
they wouldn't be needed if those extensions only have content_script
JS but not CSS.
BUG=622464
Test=None, internal cleanup.
Committed: https://crrev.com/4ff54b3aa230cb7a5f7c9b30181ff4e19d763a46
Cr-Commit-Position: refs/heads/master@{#410810}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. BUG=622464 Test=None, internal cleanup. ========== to ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. ==========
lazyboy@chromium.org changed reviewers: + asargent@chromium.org
lgtm
The CQ bit was checked by lazyboy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by lazyboy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. ========== to ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. ========== to ========== [UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. Committed: https://crrev.com/4ff54b3aa230cb7a5f7c9b30181ff4e19d763a46 Cr-Commit-Position: refs/heads/master@{#410810} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4ff54b3aa230cb7a5f7c9b30181ff4e19d763a46 Cr-Commit-Position: refs/heads/master@{#410810} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
