Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issue 2197513002: [UserScript] Do not create SubstitutionMap if not necessary. (Closed)

Created:
4 years, 4 months ago by lazyboy
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UserScript] Do not create SubstitutionMap if not necessary. Tiny improvement. We won't need to call GetLocalizationMessages for most extensions as they wouldn't be needed if those extensions only have content_script JS but not CSS. BUG=622464 Test=None, internal cleanup. Committed: https://crrev.com/4ff54b3aa230cb7a5f7c9b30181ff4e19d763a46 Cr-Commit-Position: refs/heads/master@{#410810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M extensions/browser/extension_user_script_loader.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
lazyboy
4 years, 4 months ago (2016-08-08 23:35:27 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 4 months ago (2016-08-09 00:01:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197513002/1
4 years, 4 months ago (2016-08-09 00:41:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/179971)
4 years, 4 months ago (2016-08-09 00:50:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197513002/1
4 years, 4 months ago (2016-08-09 20:31:24 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:49:33 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:52:45 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff54b3aa230cb7a5f7c9b30181ff4e19d763a46
Cr-Commit-Position: refs/heads/master@{#410810}

Powered by Google App Engine
This is Rietveld 408576698