Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197503002: Route Scroll events through a cc::InputHandler

Created:
4 years, 4 months ago by tapted
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160728-MacViews-ScrollWheelAsScrollEvent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route Scroll events through a cc::InputHandler Overview CL: http://crrev.com/2189583004 BUG=615948, 594907 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Patch Set 2 : Defer more elasticity goo #

Patch Set 3 : Do not muck with the property tree #

Patch Set 4 : Probably misguided attempt at using cc::PaintedScrollbarLayer #

Patch Set 5 : Revert "Probably misguided attempt at using cc::PaintedScrollbarLayer" #

Patch Set 6 : Set the event handled, cleanup a few things #

Patch Set 7 : rebase? #

Patch Set 8 : Retain previously scrolling layer #

Patch Set 9 : Reveal scrollers on touch #

Patch Set 10 : rebase #

Patch Set 11 : Example with example and InputReady #

Patch Set 12 : ScheduleDraw() option - this results in massive tearing #

Patch Set 13 : Abandon DeliverInputForBeginFrame: will not help fix the header row #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -3 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +16 lines, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -0 lines 0 comments Download
M ui/compositor/layer.h View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
A ui/compositor/overscroll/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
A ui/compositor/overscroll/ui_input_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +51 lines, -0 lines 0 comments Download
A ui/compositor/overscroll/ui_input_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +77 lines, -0 lines 0 comments Download
A ui/compositor/overscroll/ui_scroll_input_manager.h View 1 2 3 4 5 6 7 8 9 10 12 1 chunk +44 lines, -0 lines 0 comments Download
A ui/compositor/overscroll/ui_scroll_input_manager.cc View 1 2 3 4 5 6 7 8 9 11 12 1 chunk +30 lines, -0 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 2 3 4 5 6 7 8 9 3 chunks +18 lines, -3 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/scrollbar/scroll_bar.h View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/scrollbar/scrollbar_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 55 (55 generated)
tapted
Description was changed from ========== Route Scroll events through a cc::InputHandler BUG=615948, 594907 ========== to ...
4 years, 4 months ago (2016-07-29 07:55:49 UTC) #1
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 01:24:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/40001
4 years, 4 months ago (2016-08-08 01:24:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 01:28:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/builds/427) cast_shell_linux on ...
4 years, 4 months ago (2016-08-08 01:28:06 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 01:47:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/60001
4 years, 4 months ago (2016-08-08 01:48:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 02:26:22 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/275603)
4 years, 4 months ago (2016-08-08 02:26:23 UTC) #9
tapted
Description was changed from ========== Route Scroll events through a cc::InputHandler BUG=615948, 594907 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== ...
4 years, 4 months ago (2016-08-08 03:38:51 UTC) #10
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 06:05:46 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/100001
4 years, 4 months ago (2016-08-08 06:06:02 UTC) #12
tapted
Patchset #5 (id:80001) has been deleted
4 years, 4 months ago (2016-08-08 06:28:04 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 07:06:55 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-08-08 07:06:56 UTC) #15
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-15 06:08:40 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/200001
4 years, 4 months ago (2016-08-15 06:08:52 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-15 06:25:05 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/246557)
4 years, 4 months ago (2016-08-15 06:25:09 UTC) #19
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-15 06:56:12 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/220001
4 years, 4 months ago (2016-08-15 06:56:23 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-15 07:25:48 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/277855)
4 years, 4 months ago (2016-08-15 07:25:49 UTC) #23
tapted
Patchset #10 (id:200001) has been deleted
4 years, 4 months ago (2016-08-15 08:49:11 UTC) #24
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-28 01:43:55 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/240001
4 years, 2 months ago (2016-09-28 01:44:16 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-28 02:52:59 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/304024)
4 years, 2 months ago (2016-09-28 02:53:00 UTC) #28
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-21 06:54:07 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/340001
4 years, 2 months ago (2016-10-21 06:54:24 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-21 07:45:43 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/319934)
4 years, 2 months ago (2016-10-21 07:45:44 UTC) #32
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-24 02:58:57 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/360001
4 years, 2 months ago (2016-10-24 02:59:07 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-24 03:44:35 UTC) #35
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/320688)
4 years, 2 months ago (2016-10-24 03:44:35 UTC) #36
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-24 06:37:12 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/380001
4 years, 2 months ago (2016-10-24 06:37:23 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-24 07:51:02 UTC) #39
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-24 07:51:03 UTC) #40
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years ago (2016-12-01 01:29:22 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197503002/440001
4 years ago (2016-12-01 01:29:57 UTC) #42
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-01 01:32:34 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)
4 years ago (2016-12-01 01:32:35 UTC) #44
tapted
Patchset #21 (id:440001) has been deleted
4 years ago (2016-12-04 23:42:37 UTC) #45
tapted
Patchset #19 (id:400001) has been deleted
4 years ago (2016-12-04 23:42:48 UTC) #46
tapted
Patchset #18 (id:380001) has been deleted
4 years ago (2016-12-04 23:43:00 UTC) #47
tapted
Patchset #17 (id:360001) has been deleted
4 years ago (2016-12-04 23:43:11 UTC) #48
tapted
Patchset #13 (id:280001) has been deleted
4 years ago (2016-12-04 23:43:26 UTC) #49
tapted
Patchset #12 (id:260001) has been deleted
4 years ago (2016-12-04 23:43:37 UTC) #50
tapted
Patchset #11 (id:240001) has been deleted
4 years ago (2016-12-04 23:43:48 UTC) #51
tapted
Patchset #3 (id:40001) has been deleted
4 years ago (2016-12-04 23:44:04 UTC) #52
tapted
Patchset #3 (id:60001) has been deleted
4 years ago (2016-12-04 23:44:17 UTC) #53
tapted
Patchset #4 (id:120001) has been deleted
4 years ago (2016-12-04 23:44:28 UTC) #54
tapted
4 years ago (2016-12-04 23:44:45 UTC) #55 
Patchset #6 (id:180001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698