chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc - Issue 2197483003: Move the Mac Task Manager to the new backend code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc

Issue 2197483003: Move the Mac Task Manager to the new backend code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/task_management/task_manager_browsertest.cc » ('j') | chrome/browser/task_management/task_manager_tester.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc

diff --git a/chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc b/chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc

index 67e8649c9cf448f9f43b184b0ebf1b9e2ee8a4d0..aadade4077120783d5a240347fa3f318b83b8aaf 100644

--- a/chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc

+++ b/chrome/browser/task_management/sampling/task_manager_io_thread_helper.cc

@@ -26,7 +26,11 @@ IoThreadHelperManager::IoThreadHelperManager() {

}

IoThreadHelperManager::~IoThreadHelperManager() {

- DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

+ // This may be called at exit time when the main thread is no longer

+ // registered as the UI thread.

+ DCHECK(

+ content::BrowserThread::CurrentlyOn(content::BrowserThread::UI) ||

+ !content::BrowserThread::IsMessageLoopValid(content::BrowserThread::UI));

content::BrowserThread::PostTask(

content::BrowserThread::IO,