Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2197433002: Revert of aw: Fix FactoryProvider threading (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of aw: Fix FactoryProvider threading (patchset #3 id:40001 of https://codereview.chromium.org/2180423003/ ) Reason for revert: Broke correct usage: crbug.com/632547 BUG=632547 Original issue's description: > aw: Fix FactoryProvider threading > > Access thread-unsafe chromium classes on the UI thread only > > BUG=630709 > > Committed: https://crrev.com/993fff8648f2701910b9efdbf1d35244fbf8ca73 > Cr-Commit-Position: refs/heads/master@{#408432} TBR=torne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630709 Committed: https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e Cr-Commit-Position: refs/heads/master@{#408557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -38 lines) Patch
M android_webview/glue/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 4 chunks +13 lines, -30 lines 0 comments Download
M android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of aw: Fix FactoryProvider threading
4 years, 4 months ago (2016-07-29 02:12:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197433002/1
4 years, 4 months ago (2016-07-29 02:12:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 02:13:05 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 02:15:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e
Cr-Commit-Position: refs/heads/master@{#408557}

Powered by Google App Engine
This is Rietveld 408576698