Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2197423003: Remove now unused source files. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove now unused source files. These files have been renamed and exist only as stubs for transition reasons. Remove these now unused stubs. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/b605f89398767bc39516e1c13a1d9a23bc8e2162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +1 line, -3 lines 0 comments Download
M public.bzl View 4 chunks +0 lines, -4 lines 0 comments Download
D src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
D src/ports/SkFontHost_fontconfig.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
bungeman-skia
4 years, 4 months ago (2016-08-02 18:04:53 UTC) #10
mtklein_C
lgtm
4 years, 4 months ago (2016-08-02 18:17:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197423003/1
4 years, 4 months ago (2016-08-02 18:17:55 UTC) #14
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 4 months ago (2016-08-02 18:17:56 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:18:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b605f89398767bc39516e1c13a1d9a23bc8e2162

Powered by Google App Engine
This is Rietveld 408576698