Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: bin/fetch-gn

Issue 2197423002: Pick the right download tool for windows. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/fetch-gn
diff --git a/bin/fetch-gn b/bin/fetch-gn
index f2d3c42960ea7d29203b6e2fbecb2ed1b5b0f14d..02a3ee8c975e5c498ed3eb2969585d2f0eef7eea 100755
--- a/bin/fetch-gn
+++ b/bin/fetch-gn
@@ -19,6 +19,11 @@ def gn_path():
return 'buildtools/mac/gn'
return 'buildtools/win/gn.exe'
-quiet('download_from_google_storage',
+def download_tool():
+ if 'win' in sys.platform:
mtklein_C 2016/08/01 18:47:12 'win' in 'Darwin' :/
herb_g 2016/08/01 18:52:08 Done.
+ return 'download_from_google_storage.bat'
+ return 'download_from_google_storage'
+
+quiet(download_tool(),
'--no_resume --no_auth --bucket chromium-gn',
'-s ', gn_path() + '.sha1')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698