Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2197423002: Pick the right download tool for windows. (Closed)

Created:
4 years, 4 months ago by herb_g
Modified:
4 years, 4 months ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pick the right download tool for windows. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197423002 Committed: https://skia.googlesource.com/skia/+/35f3e59d1c9900a00f31928b83bf7c2bfe4c7647

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix OS comparison. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M bin/fetch-gn View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
https://codereview.chromium.org/2197423002/diff/1/bin/fetch-gn File bin/fetch-gn (right): https://codereview.chromium.org/2197423002/diff/1/bin/fetch-gn#newcode23 bin/fetch-gn:23: if 'win' in sys.platform: 'win' in 'Darwin' :/
4 years, 4 months ago (2016-08-01 18:47:12 UTC) #3
herb_g
Fix OS comparison.
4 years, 4 months ago (2016-08-01 18:51:27 UTC) #4
herb_g
PTAL https://codereview.chromium.org/2197423002/diff/1/bin/fetch-gn File bin/fetch-gn (right): https://codereview.chromium.org/2197423002/diff/1/bin/fetch-gn#newcode23 bin/fetch-gn:23: if 'win' in sys.platform: On 2016/08/01 18:47:12, mtklein_C ...
4 years, 4 months ago (2016-08-01 18:52:09 UTC) #5
mtklein_C
lgtm
4 years, 4 months ago (2016-08-01 18:53:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197423002/20001
4 years, 4 months ago (2016-08-01 18:53:10 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:26:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/35f3e59d1c9900a00f31928b83bf7c2bfe4c7647

Powered by Google App Engine
This is Rietveld 408576698