[Android] Add shadows-core targets for multiple apis.

[Android] Add shadows-core targets for multiple apis.

This added shadows-core-18.jar and shadows-core-21.jar targets.
This also fixes some build errors in the shadows-multidex target.

BUG=522043
Committed: https://crrev.com/048cb728c2f92f46e3239bb3c4cf553c94362f8a
Cr-Commit-Position: refs/heads/master@{#409128}

[mikecase (-- gone --), 2016-08-01 21:10:10]

Description was changed from

==========
[Android] Add shadows-core targets for multiple apis.

This added shadows-core-18.jar and shadows-core-21.jar targets.
This also fixes some build errors in the shadows-multidex target.

BUG=
==========

to

==========
[Android] Add shadows-core targets for multiple apis.

This added shadows-core-18.jar and shadows-core-21.jar targets.
This also fixes some build errors in the shadows-multidex target.

BUG=522043
==========

[mikecase (-- gone --), 2016-08-01 21:33:35]

mikecase@chromium.org changed reviewers:
+ agrieve@chromium.org, jbudorick@chromium.org

[mikecase (-- gone --), 2016-08-01 21:33:36]

Added a shadows_core template to create different versions of the Robolectric
shadows-core jar for different API levels.

The template....
(1) Processes the template files for the API level specified
(2) Compiles the processed template files along with some non-templated files
into a jar named shadows-core-3.0-<API LEVEL>.jar (name is important since
Robolectric looks for these specific names)
(3) Writes a build_config file so that this shadows-core jar will be in the
classpath for things that depend on the template. The robolectric_3_java code
has to be compiled against this code for example.

[mikecase (-- gone --), 2016-08-01 21:35:14]

This is part of https://codereview.chromium.org/2195143002 CL, which is to
upgrade our tests to Robolectric 3.0.

[jbudorick, 2016-08-01 21:39:33]

https://codereview.chromium.org/2197403003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2197403003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:56:
"//third_party/robolectric:shadows-core-3.0-21",
nit: alpha

https://codereview.chromium.org/2197403003/diff/40001/third_party/robolectric...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/2197403003/diff/40001/third_party/robolectric...
third_party/robolectric/README.chromium:9: Local Modifications:
You should mention the modification you're making to the template processor.

[mikecase (-- gone --), 2016-08-01 22:05:10]

Thanks for fastest review ever.

https://codereview.chromium.org/2197403003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2197403003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:56:
"//third_party/robolectric:shadows-core-3.0-21",
On 2016/08/01 at 21:39:33, jbudorick wrote:
> nit: alpha

Done. Also, I realized I did the build file stupidly and the shadows_core_18 and
shadows_core_21 are no longer necessary.

https://codereview.chromium.org/2197403003/diff/40001/third_party/robolectric...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/2197403003/diff/40001/third_party/robolectric...
third_party/robolectric/README.chromium:9: Local Modifications:
On 2016/08/01 at 21:39:33, jbudorick wrote:
> You should mention the modification you're making to the template processor.

Done

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
third_party/robolectric/BUILD.gn:575: java_library(target_name) {
I realized I was doing this all wrong. Before I was doing some convoluted thing
and had to use write_build_config to get the deps to work. Instead, I can just
set the java_library to target_name and everything just works.

I guess I didn't realize how templates worked...

[mikecase (-- gone --), 2016-08-01 22:19:39]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 22:19:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 23:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 23:27:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbudorick, 2016-08-01 23:33:45]

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
third_party/robolectric/BUILD.gn:541: api_level = invoker.api_level
You can use forward_variables_from for these:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
third_party/robolectric/BUILD.gn:575: java_library(target_name) {
On 2016/08/01 22:05:10, mikecase wrote:
> I realized I was doing this all wrong. Before I was doing some convoluted
thing
> and had to use write_build_config to get the deps to work. Instead, I can just
> set the java_library to target_name and everything just works.
> 
> I guess I didn't realize how templates worked...

Yeah, although you typically see this scenario as

  template("blah") {
    action1
    action2

    group(target_name) {
      deps = [
        action1,
        action2,
    }
  }

[mikecase (-- gone --), 2016-08-02 00:33:52]

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2197403003/diff/60001/third_party/robolectric...
third_party/robolectric/BUILD.gn:575: java_library(target_name) {
On 2016/08/01 at 23:33:45, jbudorick wrote:
> On 2016/08/01 22:05:10, mikecase wrote:
> > I realized I was doing this all wrong. Before I was doing some convoluted
thing
> > and had to use write_build_config to get the deps to work. Instead, I can
just
> > set the java_library to target_name and everything just works.
> > 
> > I guess I didn't realize how templates worked...
> 
> Yeah, although you typically see this scenario as
> 
>   template("blah") {
>     action1
>     action2
> 
>     group(target_name) {
>       deps = [
>         action1,
>         action2,
>     }
>   }

Done

[agrieve, 2016-08-02 00:58:35]

lgtm

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:7: java_prebuilt("tagsoup-1.2") {
nit: probably should mark these all as testonly

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:551: processed_template_files = []
nit: try and prefix all non-parameter variables with a _

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:560: base_template_output_dir =
rebase_path("$target_gen_dir", root_build_dir)
"$var"->var

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:587: additional_jar_files = [
nit: probably makes sense to make these conditional based off of is_win, is_mac,
is_linux

[mikecase (-- gone --), 2016-08-02 02:03:50]

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:7: java_prebuilt("tagsoup-1.2") {
On 2016/08/02 at 00:58:35, agrieve wrote:
> nit: probably should mark these all as testonly

Done

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:551: processed_template_files = []
On 2016/08/02 at 00:58:35, agrieve wrote:
> nit: try and prefix all non-parameter variables with a _

k will do. prefixed the non-param vars with _

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:560: base_template_output_dir =
rebase_path("$target_gen_dir", root_build_dir)
On 2016/08/02 at 00:58:35, agrieve wrote:
> "$var"->var

Done. oops. Fixed this in some other places.

https://codereview.chromium.org/2197403003/diff/80001/third_party/robolectric...
third_party/robolectric/BUILD.gn:587: additional_jar_files = [
On 2016/08/02 at 00:58:35, agrieve wrote:
> nit: probably makes sense to make these conditional based off of is_win,
is_mac, is_linux

Done

[mikecase (-- gone --), 2016-08-02 02:04:40]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-08-02 02:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2197403003/#ps100001
(title: "agrieve's nits")

[commit-bot: I haz the power, 2016-08-02 02:04:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 03:07:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-02 03:09:02]

Description was changed from

==========
[Android] Add shadows-core targets for multiple apis.

This added shadows-core-18.jar and shadows-core-21.jar targets.
This also fixes some build errors in the shadows-multidex target.

BUG=522043
==========

to

==========
[Android] Add shadows-core targets for multiple apis.

This added shadows-core-18.jar and shadows-core-21.jar targets.
This also fixes some build errors in the shadows-multidex target.

BUG=522043

Committed: https://crrev.com/048cb728c2f92f46e3239bb3c4cf553c94362f8a
Cr-Commit-Position: refs/heads/master@{#409128}
==========

[commit-bot: I haz the power, 2016-08-02 03:09:03]

Patchset 6 (id:??) landed as
https://crrev.com/048cb728c2f92f46e3239bb3c4cf553c94362f8a
Cr-Commit-Position: refs/heads/master@{#409128}