Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2197393002: Show "pages" not "sheets of paper" on print to drive. (Closed)

Created:
4 years, 4 months ago by rbpotter
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show "pages" not "sheets of paper" on print to drive. Top left message box printed "sheets of paper" message when printing to Google Drive. Modified so it simply states the number of pages, as with print to PDF. BUG=632758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4877039e4e820d2c9ab5d27c853feaa6829e53d9 Cr-Commit-Position: refs/heads/master@{#409067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/resources/print_preview/print_header.js View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rbpotter
4 years, 4 months ago (2016-08-01 18:51:22 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-01 20:32:14 UTC) #5
dpapad
lgtm
4 years, 4 months ago (2016-08-01 20:44:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197393002/1
4 years, 4 months ago (2016-08-01 22:10:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 22:25:49 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:38:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4877039e4e820d2c9ab5d27c853feaa6829e53d9
Cr-Commit-Position: refs/heads/master@{#409067}

Powered by Google App Engine
This is Rietveld 408576698