Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2197343002: [Offline Page]Fix pathpattern warning and delete eml support (Closed)

Created:
4 years, 4 months ago by Vivian
Modified:
4 years, 4 months ago
Reviewers:
Ted C, dewittj
CC:
chromium-reviews, fgorski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pathpattern warning and delete eml support EML is a generic MIME file format, that can contain arbitrary email messages, including attachments etc. We want to stay focus on mhtml only. BUG=633271 Committed: https://crrev.com/6538c29330b8ffc57b737829cff17d48d5e54a5d Cr-Commit-Position: refs/heads/master@{#409056}

Patch Set 1 : Fix pathpattern warning #

Patch Set 2 : Delete eml support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Vivian
ptal
4 years, 4 months ago (2016-08-01 19:18:23 UTC) #4
dewittj
lgtm
4 years, 4 months ago (2016-08-01 19:31:16 UTC) #5
Ted C
lgtm
4 years, 4 months ago (2016-08-01 20:21:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197343002/20001
4 years, 4 months ago (2016-08-01 21:10:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 21:13:52 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 21:16:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6538c29330b8ffc57b737829cff17d48d5e54a5d
Cr-Commit-Position: refs/heads/master@{#409056}

Powered by Google App Engine
This is Rietveld 408576698