Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2197333002:
Enable PrerenderTests on Android. (Closed)
|
Created:
4 years, 4 months ago by mmenke Modified:
4 years, 4 months ago Reviewers:
pasko CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable PrerenderTests on Android.
Looks like they haven't been enabled since before Android
was upstreamed to the public repo.
BUG=138275
Committed: https://crrev.com/50ec2e97b08adc6f322a49a73cc12f8063242c1c
Cr-Commit-Position: refs/heads/master@{#409182}
Patch Set 1 #Patch Set 2 : Remove DCHECK #
Total comments: 2
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Re-enable PrerenderTests on Android. It's unclear why they were disabled. BUG=138275 ========== to ========== Enable PrerenderTests on Android. Looks like they haven't been enabled since before Android was upstreamed to the public repo. BUG=138275 ==========
mmenke@chromium.org changed reviewers: + pasko@chromium.org
https://codereview.chromium.org/2197333002/diff/20001/chrome/browser/prerende... File chrome/browser/prerender/prerender_manager.cc (right): https://codereview.chromium.org/2197333002/diff/20001/chrome/browser/prerende... chrome/browser/prerender/prerender_manager.cc:278: return AddPrerender(ORIGIN_INSTANT, url, content::Referrer(), size, I could alternatively add kPrefetchSearchResults to the command line. Depending on components/search here seems a little weird, though. Doesn't really seem like this code should know about the component.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Oh, just noticed this change after replying on our other conversation. LGTM
https://codereview.chromium.org/2197333002/diff/20001/chrome/browser/prerende... File chrome/browser/prerender/prerender_manager.cc (right): https://codereview.chromium.org/2197333002/diff/20001/chrome/browser/prerende... chrome/browser/prerender/prerender_manager.cc:278: return AddPrerender(ORIGIN_INSTANT, url, content::Referrer(), size, On 2016/08/01 21:13:09, mmenke wrote: > I could alternatively add kPrefetchSearchResults to the command line. Depending > on components/search here seems a little weird, though. Doesn't really seem > like this code should know about the component. Acknowledged.
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable PrerenderTests on Android. Looks like they haven't been enabled since before Android was upstreamed to the public repo. BUG=138275 ========== to ========== Enable PrerenderTests on Android. Looks like they haven't been enabled since before Android was upstreamed to the public repo. BUG=138275 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable PrerenderTests on Android. Looks like they haven't been enabled since before Android was upstreamed to the public repo. BUG=138275 ========== to ========== Enable PrerenderTests on Android. Looks like they haven't been enabled since before Android was upstreamed to the public repo. BUG=138275 Committed: https://crrev.com/50ec2e97b08adc6f322a49a73cc12f8063242c1c Cr-Commit-Position: refs/heads/master@{#409182} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/50ec2e97b08adc6f322a49a73cc12f8063242c1c Cr-Commit-Position: refs/heads/master@{#409182} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
