Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: sdk/lib/_internal/pub/test/serve/404_page_test.dart

Issue 219733002: Make a slightly better 404 page for pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/base_server.dart ('k') | sdk/lib/_internal/pub/test/serve/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/serve/404_page_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/404_page_test.dart b/sdk/lib/_internal/pub/test/serve/404_page_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..d37c387caaab0e16efd434609c95f925fd37e014
--- /dev/null
+++ b/sdk/lib/_internal/pub/test/serve/404_page_test.dart
@@ -0,0 +1,47 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library pub_tests;
+
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../descriptor.dart' as d;
+import '../test_pub.dart';
+import 'utils.dart';
+
+main() {
+ initConfig();
+ setUp(() {
+ d.dir(appPath, [
+ d.appPubspec()
+ ]).create();
+ });
+
+ integration("the 404 page describes the missing asset", () {
+ pubServe();
+
+ scheduleRequest("packages/foo/missing.txt").then((response) {
+ expect(response.statusCode, equals(404));
+
+ // Should mention the asset that can't be found.
+ expect(response.body, contains("foo"));
+ expect(response.body, contains("missing.txt"));
+ });
+
+ endPubServe();
+ });
+
+ integration("the 404 page describes the error", () {
+ pubServe();
+
+ scheduleRequest("packages").then((response) {
+ expect(response.statusCode, equals(404));
+
+ // Should mention the asset that can't be found.
+ expect(response.body, contains('"/packages"'));
+ });
+
+ endPubServe();
+ });
+}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/base_server.dart ('k') | sdk/lib/_internal/pub/test/serve/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698