Replace old SkRecords RefBox with sk_sp.

Replace old SkRecords RefBox with sk_sp.

The main differences are that RefBox's constructor reffed and sk_sp's doesn't,
and that RefBox auto-casts to the underlying pointer while sk_sp doesn't.

I've added a bunch of sk_ref_sp() and .get() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003

Committed: https://skia.googlesource.com/skia/+/da574d17f864ed70323a1c0fc6e4e969153a4c98

[mtklein_C, 2016-08-01 16:45:12]

Description was changed from

==========
Replace old SkRecords RefBox with sk_sp.

The main difference is that RefBox's constructor reffed and sk_sp's
definitely doesn't.  I've added a bunch of sk_ref_sp() to compensate.

BUG=skia:
==========

to

==========
Replace old SkRecords RefBox with sk_sp.

The main difference is that RefBox's constructor reffed and sk_sp's
definitely doesn't.  I've added a bunch of sk_ref_sp() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003
==========

[mtklein_C, 2016-08-01 16:47:48]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 16:47:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 16:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 16:51:04]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-08-01 17:03:31]

Description was changed from

==========
Replace old SkRecords RefBox with sk_sp.

The main difference is that RefBox's constructor reffed and sk_sp's
definitely doesn't.  I've added a bunch of sk_ref_sp() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003
==========

to

==========
Replace old SkRecords RefBox with sk_sp.

The main differences are that RefBox's constructor reffed and sk_sp's doesn't,
and that RefBox auto-casts to the underlying pointer while sk_sp doesn't.

I've added a bunch of sk_ref_sp() and .get() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003
==========

[mtklein_C, 2016-08-01 17:03:34]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 17:03:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-01 17:09:57]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-08-01 17:09:58]

This makes it a lot easier to replace images in SkRecords with their
makeTextureImage().

[commit-bot: I haz the power, 2016-08-01 17:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:33:50]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-01 18:22:37]

lgtm

[mtklein_C, 2016-08-01 18:22:43]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-01 18:22:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 18:24:05]

Description was changed from

==========
Replace old SkRecords RefBox with sk_sp.

The main differences are that RefBox's constructor reffed and sk_sp's doesn't,
and that RefBox auto-casts to the underlying pointer while sk_sp doesn't.

I've added a bunch of sk_ref_sp() and .get() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003
==========

to

==========
Replace old SkRecords RefBox with sk_sp.

The main differences are that RefBox's constructor reffed and sk_sp's doesn't,
and that RefBox auto-casts to the underlying pointer while sk_sp doesn't.

I've added a bunch of sk_ref_sp() and .get() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003

Committed:
https://skia.googlesource.com/skia/+/da574d17f864ed70323a1c0fc6e4e969153a4c98
==========

[commit-bot: I haz the power, 2016-08-01 18:24:06]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/da574d17f864ed70323a1c0fc6e4e969153a4c98