Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2197243002: Rename build-root to library-root (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename build-root to library-root First step on #557. Will eliminate the deprecated flag once upstream uses are switched over. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/4219a9e3c073f44a804c09f6325b56c7af35b14e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M lib/src/compiler/code_generator.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M lib/src/compiler/command.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M lib/src/compiler/compiler.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 4 months ago (2016-08-01 15:15:44 UTC) #3
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-01 15:27:50 UTC) #4
vsm
4 years, 4 months ago (2016-08-01 15:30:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4219a9e3c073f44a804c09f6325b56c7af35b14e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698