Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 219723003: Remove all uses of GG_UINT32_C. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, pwestin+watch_google.com, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, feature-media-reviews_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

Remove all uses of GG_UINT32_C. We can use UINT32_C from <stdint.h>, since we force-define __STDC_CONSTANT_MACROS. As a "drive-by", also remove all the other uses of GG_... from media/cast (since I'll do it later anyway). R=hclam@chromium.org TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260816

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -34 lines) Patch
M base/port.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/audio_receiver/audio_receiver_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/audio_sender/audio_encoder_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/cast_defines.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/congestion_control/congestion_control_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M media/cast/framer/cast_message_builder_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/logging/logging_impl_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M media/cast/rtp_receiver/receiver_stats_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/test/encode_decode_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport_defines.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport_sender_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/transport/pacing/paced_sender_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_decoder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
lgtm
6 years, 8 months ago (2014-03-31 19:26:43 UTC) #1
viettrungluu
Thanks, Alpha. brettw --> base approval?
6 years, 8 months ago (2014-03-31 23:39:25 UTC) #2
viettrungluu
brettw --> TBR, because there's a chance the CQ will succeed on this
6 years, 8 months ago (2014-04-01 03:07:05 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-01 03:07:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/219723003/40001
6 years, 8 months ago (2014-04-01 03:07:39 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 09:30:09 UTC) #6
Message was sent while issue was closed.
Change committed as 260816

Powered by Google App Engine
This is Rietveld 408576698