Issue 219723002: always lookup api holder from receiver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219723002: always lookup api holder from receiver (Closed)

Created:
6 years, 8 months ago by dcarney

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

always lookup api holder from receiver R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20392

Patch Set 1 #

Patch Set 2 : remove unnecessary guards #

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/hydrogen.cc	View	1 2	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dcarney

Committed patchset #3 manually as r20392 (presubmit successful).

6 years, 8 months ago (2014-04-01 11:21:38 UTC) #3

haraken

On 2014/04/01 11:21:38, dcarney wrote: > Committed patchset #3 manually as r20392 (presubmit successful). It ...

6 years, 8 months ago (2014-04-04 06:44:57 UTC) #4

dcarney

6 years, 8 months ago (2014-04-04 06:57:56 UTC) #5

Message was sent while issue was closed.

On 2014/04/04 06:44:57, haraken wrote:
> On 2014/04/01 11:21:38, dcarney wrote:
> > Committed patchset #3 manually as r20392 (presubmit successful).
> 
> It looks like this CL is rolled to Chromium. (Chromium DEPS is saying that the
> V8 revision is r20418.) May I land the Blink-side CL that moves DOM attributes
> to prototype chains?

that v8 seems stable. go for it

Expand Messages | Collapse Messages