Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2197203003: Rebind mus keyboard shortcut for dump ServerWindow hierarchy to Ctrl-Alt-Shift-M (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebind mus keyboard shortcut for dump ServerWindow hierarchy to Ctrl-Alt-Shift-M This avoids a DCHECK on startup when running chrome --mash --ash-debug-shortcuts. The previous accelerator Ctrl-Alt-Shift-S was already used by ash. BUG=633270 TEST=manual

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/common/accelerators/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/window_manager_state.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (5 generated)
James Cook
sky, PTAL This is just a band-aid to fix the startup DCHECK. I still get ...
4 years, 4 months ago (2016-08-01 18:05:42 UTC) #4
sky
https://codereview.chromium.org/2197203003/diff/1/services/ui/ws/window_manager_state.cc File services/ui/ws/window_manager_state.cc (right): https://codereview.chromium.org/2197203003/diff/1/services/ui/ws/window_manager_state.cc#newcode370 services/ui/ws/window_manager_state.cc:370: ui::mojom::KeyboardCode::M, ui::mojom::kEventFlagControlDown | I think the wm should be ...
4 years, 4 months ago (2016-08-01 20:43:20 UTC) #7
James Cook
4 years, 4 months ago (2016-08-01 21:25:59 UTC) #8
On 2016/08/01 20:43:20, sky wrote:
>
https://codereview.chromium.org/2197203003/diff/1/services/ui/ws/window_manag...
> File services/ui/ws/window_manager_state.cc (right):
> 
>
https://codereview.chromium.org/2197203003/diff/1/services/ui/ws/window_manag...
> services/ui/ws/window_manager_state.cc:370: ui::mojom::KeyboardCode::M,
> ui::mojom::kEventFlagControlDown |
> I think the wm should be able to override debug accelerators, otherwise we get
> errors like we're seeing.
> 
> I also think debug accelerators should always be processed. So, if the wm
binds
> an accelerator mus defines both are processed.

OK, I'll abandon this CL.

Powered by Google App Engine
This is Rietveld 408576698