[debugger] use handler table on unoptimized code for exception prediction.

[debugger] use handler table on unoptimized code for exception prediction.

R=mstarzinger@chromium.org

Committed: https://crrev.com/1515ddd8f1558d898eae91b43e564cba62ced173
Cr-Commit-Position: refs/heads/master@{#38247}

[Yang, 2016-08-02 08:48:03]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 08:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 08:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 08:49:22]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6083)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20722)

[Yang, 2016-08-02 08:58:21]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 08:58:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 09:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 09:01:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6085)

[Michael Starzinger, 2016-08-02 11:04:05]

LGTM. Just nits.

https://codereview.chromium.org/2197183002/diff/80001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/2197183002/diff/80001/src/frames.cc#newcode1237
src/frames.cc:1237: DCHECK_NULL(prediction);
nit: Can we add a comment saying that predictions are unsupported by optimized
code and must be retrieved via a {FrameSummary} instead. Just for posterity.

https://codereview.chromium.org/2197183002/diff/80001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2197183002/diff/80001/src/objects.h#newcode4650
src/objects.h:4650: int LookupRangeInHandlerTable(int code_offset, int*
context_register,
nit: s/context_register/data/ here, because for FCG code this is the stack depth
and not the context register.

https://codereview.chromium.org/2197183002/diff/80001/src/objects.h#newcode5346
src/objects.h:5346: int LookupRangeInHandlerTable(int code_offset, int*
context_register,
nit: s/context_register/data/

https://codereview.chromium.org/2197183002/diff/80001/src/objects.h#newcode5564
src/objects.h:5564: int code_offset, int* context_register,
nit: s/context_register/data/

[Yang, 2016-08-02 13:18:09]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-08-02 13:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2197183002/#ps100001
(title: "address comments and rebase")

[commit-bot: I haz the power, 2016-08-02 13:18:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 13:47:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-02 13:47:59]

Description was changed from

==========
[debugger] use handler table on unoptimized code for exception prediction.

R=mstarzinger@chromium.org
==========

to

==========
[debugger] use handler table on unoptimized code for exception prediction.

R=mstarzinger@chromium.org

Committed: https://crrev.com/1515ddd8f1558d898eae91b43e564cba62ced173
Cr-Commit-Position: refs/heads/master@{#38247}
==========

[commit-bot: I haz the power, 2016-08-02 13:48:00]

Patchset 6 (id:??) landed as
https://crrev.com/1515ddd8f1558d898eae91b43e564cba62ced173
Cr-Commit-Position: refs/heads/master@{#38247}