Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2197153002:
[tools/perf] Remove deprecated memory.* benchmarks (Closed)
Description[tools/perf] Remove deprecated memory.* benchmarks
Remove the benchmarks:
- memory.mobile_memory
- memory.top_7_stress
Also remove the (now unused) memory.Memory page test.
BUG=632021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/fa8eea695d0c9a705b21bac31ef01eaf4d9e638f
Cr-Commit-Position: refs/heads/master@{#409577}
Patch Set 1 #
Total comments: 1
Patch Set 2 : remove from smoke tests #
Messages
Total messages: 28 (18 generated)
Description was changed from ========== [tools/perf] Remove deprecated memory.* benchmarks Remove the benchmarks: - memory.mobile_memory - memory.top_7_stress Also remove the (now unused) memory.Memory page test. BUG=632021 ========== to ========== [tools/perf] Remove deprecated memory.* benchmarks Remove the benchmarks: - memory.mobile_memory - memory.top_7_stress Also remove the (now unused) memory.Memory page test. BUG=632021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
perezju@chromium.org changed reviewers: + eakuefner@chromium.org, nednguyen@google.com, primiano@chromium.org
LGTM https://codereview.chromium.org/2197153002/diff/1/tools/perf/measurements/mem... File tools/perf/measurements/memory.py (left): https://codereview.chromium.org/2197153002/diff/1/tools/perf/measurements/mem... tools/perf/measurements/memory.py:38: options.AppendExtraBrowserArgs('--memory-metrics') Note to self: I should be now able to land https://codereview.chromium.org/1654863003/ (% rebase) I think this was making the telemetry tests red there.
Ping. Ned, can you have a look?
The CQ bit was checked by nednguyen@google.com
lgtm
On 2016/08/02 16:52:24, nednguyen wrote: > lgtm Sorry for the delay. Thanks so much for simplifying our codebase!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by perezju@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by perezju@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by perezju@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by perezju@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2197153002/#ps20001 (title: "remove from smoke tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Remove deprecated memory.* benchmarks Remove the benchmarks: - memory.mobile_memory - memory.top_7_stress Also remove the (now unused) memory.Memory page test. BUG=632021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [tools/perf] Remove deprecated memory.* benchmarks Remove the benchmarks: - memory.mobile_memory - memory.top_7_stress Also remove the (now unused) memory.Memory page test. BUG=632021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/fa8eea695d0c9a705b21bac31ef01eaf4d9e638f Cr-Commit-Position: refs/heads/master@{#409577} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fa8eea695d0c9a705b21bac31ef01eaf4d9e638f Cr-Commit-Position: refs/heads/master@{#409577} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
