Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2197143002: Revert of ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest CreateAndGetCapabilities (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, phoglund+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, tnakamura+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest CreateAndGetCapabilities (patchset #3 id:120001 of https://codereview.chromium.org/2190523004/ ) Reason for revert: This test is failing very frequently on some WebRTC Windows Tester bots. See https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/27190 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/5191 Sample failure: [ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 [5124:280:0729/121801:1241877:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed [2992:3628:0729/121801:1242001:ERROR:node_controller.cc(1099)] Could not be introduced to peer 37958025A53036C9.F5421BDB493A3697 [ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (231 ms) [110/110] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (475 ms) Retrying 1 test (retry #2) [ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 [2144:1880:0729/121801:1242360:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed [840:5900:0729/121801:1242469:ERROR:node_controller.cc(1099)] Could not be introduced to peer F1D75502164167AB.19D704C0D84D5C28 [ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (213 ms) [111/111] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (455 ms) Retrying 1 test (retry #3) [ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 [5628:5100:0729/121801:1242813:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed [5096:5328:0729/121802:1242937:ERROR:node_controller.cc(1099)] Could not be introduced to peer 9CA25151C497950C.94F1247A9239863C [ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (199 ms) [112/112] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (515 ms) 1 test failed: WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc:67) Original issue's description: > ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest > > This CL adds a content_browsertest for ImageCapture: > WebRtcImageCaptureBrowserTest, with one test case, > CreateAndGetCapabilities, that is parameterized to > exercise the FakeVideoCaptureDevice and, in the very > near future, the system's device if implemented > (i.e., Android). > > WebRtcImageCaptureBrowserTest needs access to the > physical webcam, but in general content_browsertests > are always using the Fake. WebRtcWebcamBrowserTest has > the necessary infrastructure to do this, so it's made > public and reused as base class for the former. > > Also, this CL moves > content/test/webrtc_content_browsertest_base.{cc,h} > to > content/browser/media/webrtc/ > since they are purely internal to content_browsertests. > > BUG=627537, 518807 > TEST=new content_browsertests > WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 > (all platforms) > > Committed: https://crrev.com/13c7a2dfcd26e94f607a169de86b937fa21fb236 > Cr-Commit-Position: refs/heads/master@{#408690} TBR=phoglund@chromium.org,sergeyu@chromium.org,avi@chromium.org,mcasas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=627537, 518807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -376 lines) Patch
M content/browser/media/capture/image_capture_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_browsertest_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_browsertest_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/media/webrtc/webrtc_content_browsertest_base.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/media/webrtc/webrtc_content_browsertest_base.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M content/browser/media/webrtc/webrtc_datachannel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/browser/media/webrtc/webrtc_image_capture_browsertest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M content/browser/media/webrtc/webrtc_ip_permissions_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/media/webrtc/webrtc_webcam_browsertest.h View 1 chunk +0 lines, -35 lines 0 comments Download
M content/browser/media/webrtc/webrtc_webcam_browsertest.cc View 2 chunks +23 lines, -19 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +3 lines, -5 lines 0 comments Download
D content/test/data/media/image_capture_test.html View 1 chunk +0 lines, -55 lines 0 comments Download
A content/test/webrtc_content_browsertest_base.h View 1 chunk +47 lines, -0 lines 0 comments Download
A content/test/webrtc_content_browsertest_base.cc View 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Guido Urdaneta
Created Revert of ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest CreateAndGetCapabilities
4 years, 4 months ago (2016-08-01 10:20:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197143002/1
4 years, 4 months ago (2016-08-01 10:21:00 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 10:22:33 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698