Chromium Code Reviews
DescriptionRevert of ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest CreateAndGetCapabilities (patchset #3 id:120001 of https://codereview.chromium.org/2190523004/ )
Reason for revert:
This test is failing very frequently on some WebRTC Windows Tester bots.
See https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/27190
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/5191
Sample failure:
[ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[5124:280:0729/121801:1241877:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed
[2992:3628:0729/121801:1242001:ERROR:node_controller.cc(1099)] Could not be introduced to peer 37958025A53036C9.F5421BDB493A3697
[ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (231 ms)
[110/110] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (475 ms)
Retrying 1 test (retry #2)
[ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[2144:1880:0729/121801:1242360:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed
[840:5900:0729/121801:1242469:ERROR:node_controller.cc(1099)] Could not be introduced to peer F1D75502164167AB.19D704C0D84D5C28
[ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (213 ms)
[111/111] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (455 ms)
Retrying 1 test (retry #3)
[ RUN ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[5628:5100:0729/121801:1242813:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77): error: Failed
[5096:5328:0729/121802:1242937:ERROR:node_controller.cc(1099)] Could not be introduced to peer 9CA25151C497950C.94F1247A9239863C
[ FAILED ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where GetParam() = 1-byte object <01> (199 ms)
[112/112] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (515 ms)
1 test failed:
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc:67)
Original issue's description:
> ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest
>
> This CL adds a content_browsertest for ImageCapture:
> WebRtcImageCaptureBrowserTest, with one test case,
> CreateAndGetCapabilities, that is parameterized to
> exercise the FakeVideoCaptureDevice and, in the very
> near future, the system's device if implemented
> (i.e., Android).
>
> WebRtcImageCaptureBrowserTest needs access to the
> physical webcam, but in general content_browsertests
> are always using the Fake. WebRtcWebcamBrowserTest has
> the necessary infrastructure to do this, so it's made
> public and reused as base class for the former.
>
> Also, this CL moves
> content/test/webrtc_content_browsertest_base.{cc,h}
> to
> content/browser/media/webrtc/
> since they are purely internal to content_browsertests.
>
> BUG=627537, 518807
> TEST=new content_browsertests
> WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
> (all platforms)
>
> Committed: https://crrev.com/13c7a2dfcd26e94f607a169de86b937fa21fb236
> Cr-Commit-Position: refs/heads/master@{#408690}
TBR=phoglund@chromium.org,sergeyu@chromium.org,avi@chromium.org,mcasas@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627537, 518807
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|