Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2197123002: [test] Remove deprecated --ignition test-runner flag (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, bradnelson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove deprecated --ignition test-runner flag The flag was introduced for ignition development. It can only be used when running ignition tests in isolation on the bots. The bots only use ignition_turbo in isolation since a while and don't pass the --ignition flag anymore. BUG=v8:5238 Committed: https://crrev.com/a23a74a7be6890655152c348ab3a3f3fc389e30f Cr-Commit-Position: refs/heads/master@{#38206}

Patch Set 1 #

Patch Set 2 : Remove obsolete expectation #

Patch Set 3 : Remove more obsolete status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M test/cctest/cctest.status View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 4 chunks +14 lines, -13 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/run-deopt-fuzzer.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/run-tests.py View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Michael Achenbach
PTAL. CC Bradley, as it removes/changes some (partially obsolete) TODOs of yours.
4 years, 4 months ago (2016-08-01 11:11:48 UTC) #16
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-01 11:20:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197123002/40001
4 years, 4 months ago (2016-08-01 12:08:56 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 12:10:36 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 12:11:55 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a23a74a7be6890655152c348ab3a3f3fc389e30f
Cr-Commit-Position: refs/heads/master@{#38206}

Powered by Google App Engine
This is Rietveld 408576698