ui/events/test/keyboard_layout.cc - Issue 2197113002: Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/test/keyboard_layout.cc

Issue 2197113002: Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Share keyboard layout selection code between tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/chromedriver/keycode_text_conversion_unittest.cc ('K') | « ui/events/test/keyboard_layout.h ('k') | ui/events/test/keyboard_layout_mac.cc » ('j') | ui/events/test/keyboard_layout_mac.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/events/test/keyboard_layout.h"

	6

	7 #if defined(OS_WIN) \|\| defined(OS_MACOSX)

	8 #include "base/logging.h"

	9

	10 namespace ui {

	11

	12 ScopedKeyboardLayout::ScopedKeyboardLayout(KeyboardLayout layout) {

	13 original_layout_ = GetActiveLayout();

	14 CHECK(ActivateLayout(GetPlatformKeyboardLayout(layout)));
	Peter Kasting 2016/08/18 17:48:19 Nit: We normally use CHECK only for security-sensi Nit: We normally use CHECK only for security-sensitive issues and temporary debugging of DCHECKs that are failing. If you have no reason to expect that ActivateLayout() should fail (which is what this code says), I would just make it return void and remove the CHECK from here. (You can add DCHECKs to the implementation of that function if you want.) Tomasz Moniuszko 2016/08/26 08:53:12 Done. Show quoted text On 2016/08/18 17:48:19, Peter Kasting wrote: > Nit: We normally use CHECK only for security-sensitive issues and temporary > debugging of DCHECKs that are failing. > > If you have no reason to expect that ActivateLayout() should fail (which is what > this code says), I would just make it return void and remove the CHECK from > here. (You can add DCHECKs to the implementation of that function if you want.) Done.
	15 }

	16

	17 ScopedKeyboardLayout::~ScopedKeyboardLayout() {

	18 ActivateLayout(original_layout_);

	19 }

	20

	21 } // namespace ui

	22

	23 #endif // defined(OS_WIN) \|\| defined(OS_MACOSX)

OLD	NEW