Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

ui/views/controls/textfield/textfield_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
@@ skipping 751 matching lines @@
   SendKeyEvent(ui::VKEY_1, false, false, false, true);
 
   // On Mac, Caps+Shift remains uppercase.
   if (TestingNativeMac())
     EXPECT_STR_EQ("TeXT!1!1", textfield_->text());
   else
     EXPECT_STR_EQ("TexT!1!1", textfield_->text());
 }
 
 TEST_F(TextfieldTest, KeysWithModifiersTest) {
+#if defined(OS_WIN)
+  // Load U.S. English keyboard layout. Modifier keys in other layouts may
+  // change the text inserted into a texfield and cause this test to fail.
+  ::LoadKeyboardLayout(L"00000409", KLF_ACTIVATE);

[Peter Kasting, 2016/08/03 00:13:26]

Don't you need to call ActivateKeyboardLayout() as well?  More generally, can
chrome/test/chromedriver/test_util.cc and here share code somehow, since they
both want to do the same thing?

After that, you probably want to ASSERT that the return value is the locale you
wanted, as current callers of SwitchKeyboardLayout() tend to do.

Nit: :: is unnecessary

[Tomasz Moniuszko, 2016/08/18 15:18:10]

Done. Code is now shared between chromedriver_test, events_unittests and
views_unittests. I also fixed KeyConverter.AllEnglishKeyboardSymbols test which
was also failing with non-English keyboard layout.

+#endif
+
   InitTextfield();
   const int ctrl = ui::EF_CONTROL_DOWN;
   const int alt = ui::EF_ALT_DOWN;
   const int command = ui::EF_COMMAND_DOWN;
   const int altgr = ui::EF_ALTGR_DOWN;
   const int shift = ui::EF_SHIFT_DOWN;
 
   SendKeyPress(ui::VKEY_T, shift | alt | altgr);
   SendKeyPress(ui::VKEY_H, alt);
   SendKeyPress(ui::VKEY_E, altgr);
@@ skipping 1971 matching lines @@
 
   textfield_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
   ui::AXViewState state_protected;
   textfield_->GetAccessibleState(&state_protected);
   EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, state_protected.role);
   EXPECT_EQ(ASCIIToUTF16("********"), state_protected.value);
   EXPECT_TRUE(state_protected.HasStateFlag(ui::AX_STATE_PROTECTED));
 }
 
 }  // namespace views