Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2196993002:
Revert of Try yet again to flip official win builders to GN. (Closed)
DescriptionRevert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )
Reason for revert:
All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
This seems to be the most likely cause :(
There's also an outstanding issue with win-pgo (see BUG=)
BUG=632864
Original issue's description:
> Try yet again to flip official win builders to GN.
>
> TBR=brettw@chromium.org
> NOTRY=true
> BUG=623659
>
> Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> Cr-Commit-Position: refs/heads/master@{#408782}
TBR=brettw@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659
NOTRY=true
Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8
Cr-Commit-Position: refs/heads/master@{#408896}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
The CQ bit was checked by tapted@chromium.org
Created Revert of Try yet again to flip official win builders to GN.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tapted@chromium.org
Description was changed from ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 ========== to ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ==========
It pains me to do it, but NaCl is still totally busted with dpranke's CLs cycled, so I've gotta try this. I'll unrevert ASAP if things don't cycle green.
Description was changed from ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ========== to ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( There's also an outstanding issue with win-pgo (see BUG=) BUG=632864 Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ==========
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( There's also an outstanding issue with win-pgo (see BUG=) BUG=632864 Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ========== to ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( There's also an outstanding issue with win-pgo (see BUG=) BUG=632864 Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( There's also an outstanding issue with win-pgo (see BUG=) BUG=632864 Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true ========== to ========== Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ ) Reason for revert: All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui... This seems to be the most likely cause :( There's also an outstanding issue with win-pgo (see BUG=) BUG=632864 Original issue's description: > Try yet again to flip official win builders to GN. > > TBR=brettw@chromium.org > NOTRY=true > BUG=623659 > > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3 > Cr-Commit-Position: refs/heads/master@{#408782} TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623659 NOTRY=true Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8 Cr-Commit-Position: refs/heads/master@{#408896} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8 Cr-Commit-Position: refs/heads/master@{#408896}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2192393003/ by tapted@chromium.org. The reason for reverting is: Didn't help - NaCl still crashing. .
Message was sent while issue was closed.
On 2016/08/01 01:26:41, tapted wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2192393003/ by mailto:tapted@chromium.org. > > The reason for reverting is: Didn't help - NaCl still crashing. . Yeah ... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
