Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2196963002: Add a new class AcceleratedStaticBitmap : StaticBitmapImage (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new class AcceleratedStaticBitmap : StaticBitmapImage At this moment, the StaticBitmapImage holds RefPtr to a SkImage, or a WebExternalTextureMailbox. So there are in total of three cases: 1). The SkImage is not texture backed. 2). The SkImage is GPU texture backed. 3). The SkImage is null, but has a valid mailbox. It makes more sense to break this class into two classes. So this CL adds a new class called AcceleratedStaticBitmap, inherited from the StaticBitmapImage class, is in charge of case 2 and 3. Case 1 is handled by the StaticBitmapImage class. We can use the bots (including the GPU_Optional bots) to make sure this change doesn't break anything. BUG=632722 Committed: https://crrev.com/23b4e88d6090ae9f2b2fa9aa062152900c09f7e9 Cr-Commit-Position: refs/heads/master@{#409238}

Patch Set 1 #

Patch Set 2 : fix error + clean up #

Patch Set 3 : rebase + minor clean up #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -213 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h View 1 chunk +36 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp View 1 4 chunks +47 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 2 chunks +9 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 1 2 3 chunks +3 lines, -117 lines 1 comment Download

Messages

Total messages: 16 (10 generated)
xidachen
PTAL PS#2 passes many bots, and PS#3 is almost identical as PS#2.
4 years, 4 months ago (2016-08-02 02:05:12 UTC) #2
Justin Novosad
lgtm https://codereview.chromium.org/2196963002/diff/40001/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp File third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp (right): https://codereview.chromium.org/2196963002/diff/40001/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp#newcode23 third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp:23: return AcceleratedStaticBitmapImage::create(image); Excellent!
4 years, 4 months ago (2016-08-02 15:26:01 UTC) #3
f(malita)
Thanks for refactoring this, LGTM.
4 years, 4 months ago (2016-08-02 15:42:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196963002/40001
4 years, 4 months ago (2016-08-02 17:58:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 18:04:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:07:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23b4e88d6090ae9f2b2fa9aa062152900c09f7e9
Cr-Commit-Position: refs/heads/master@{#409238}

Powered by Google App Engine
This is Rietveld 408576698