Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2196953003: Remove GYP builders from chromium mac, win waterfalls. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove GYP builders from chromium mac, win waterfalls. This removes the following builders: - chromium.mac - ios-device-gn (since ios-device is also gn) - ios-simulator-gn (since ios-simulator is also gn) - Mac GYP - Mac GYP (dbg) - chromium.win - Win8 GYP - Win8 GYP (dbg) - tryserver.chromium.mac - ios-device-gn (since ios-device is also gn) - ios-simulator-gn (since ios-simulator is also gn) - mac_chromium_gyp_dbg - mac_chromium_gyp_rel - tryserver.chromium.win - win8_chromium_gyp_dbg - win8_chromium_gyp_rel TBR=brettw@chromium.org BUG=432967 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1a3e965f3186ca7d59b84cc176e0a73ba2c0967d

Patch Set 1 #

Patch Set 2 : remove .expected files #

Patch Set 3 : fix dangling references #

Patch Set 4 : remove unused suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3469 lines) Patch
M masters/master.chromium.mac/master_ios_cfg.py View 1 chunk +0 lines, -4 lines 0 comments Download
M masters/master.chromium.mac/master_mac_cfg.py View 2 chunks +0 lines, -4 lines 0 comments Download
M masters/master.chromium.mac/slaves.cfg View 1 chunk +0 lines, -22 lines 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 2 chunks +0 lines, -4 lines 0 comments Download
M masters/master.chromium.win/slaves.cfg View 1 chunk +0 lines, -16 lines 0 comments Download
M masters/master.tryserver.chromium.mac/master.cfg View 1 2 4 chunks +0 lines, -21 lines 0 comments Download
M masters/master.tryserver.chromium.mac/slaves.cfg View 2 chunks +0 lines, -4 lines 0 comments Download
M masters/master.tryserver.chromium.win/master.cfg View 1 chunk +0 lines, -8 lines 0 comments Download
M masters/master.tryserver.chromium.win/slaves.cfg View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_mac.py View 2 chunks +0 lines, -38 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_win.py View 2 chunks +0 lines, -44 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 2 chunks +0 lines, -16 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP.json View 1 1 chunk +0 lines, -487 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP__dbg_.json View 1 1 chunk +0 lines, -487 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json View 1 1 chunk +0 lines, -480 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json View 1 1 chunk +0 lines, -480 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_dbg.json View 1 1 chunk +0 lines, -330 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_rel.json View 1 1 chunk +0 lines, -330 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_dbg.json View 1 1 chunk +0 lines, -345 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_rel.json View 1 1 chunk +0 lines, -345 lines 0 comments Download
M tests/masters_recipes_test.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Dirk Pranke
https://codereview.chromium.org/2200573002/ must land before this, to not break the CQ.
4 years, 4 months ago (2016-07-31 19:53:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196953003/60001
4 years, 4 months ago (2016-07-31 21:00:39 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/1a3e965f3186ca7d59b84cc176e0a73ba2c0967d
4 years, 4 months ago (2016-07-31 21:04:48 UTC) #13
brettw
4 years, 4 months ago (2016-07-31 23:24:06 UTC) #14
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698