mash: Migrate shelf tooltip manager tests to ash/common.

mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org

Committed: https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6
Cr-Commit-Position: refs/heads/master@{#408998}

[msw, 2016-07-30 01:04:53]

Patchset #2 (id:20001) has been deleted

[msw, 2016-07-30 01:05:03]

Patchset #1 (id:1) has been deleted

[msw, 2016-07-30 01:07:59]

Description was changed from

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.

BUG=629255
TEST=automated
R=jamescook@chromium.org
==========

to

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org
==========

[msw, 2016-07-30 01:08:22]

Hey James, please take a look as you have time; thanks!

[msw, 2016-07-30 01:08:33]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 01:08:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:43:29]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-01 16:58:03]

LGTM

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_tooltip_manager_unittest.cc (right):

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_tooltip_manager_unittest.cc:10: #include
"ash/common/shell_window_ids.h"
nit: remove

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_tooltip_manager_unittest.cc:39:
std::unique_ptr<views::Widget> CreateTestWidget() {
Odd that AshTestBase::CreateTestWidget doesn't work. It's gotta be something
about the container init. <shrug> I'm fine with this as-is.

[msw, 2016-08-01 17:25:46]

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_tooltip_manager_unittest.cc (right):

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_tooltip_manager_unittest.cc:10: #include
"ash/common/shell_window_ids.h"
On 2016/08/01 16:58:03, James Cook wrote:
> nit: remove

Done.

https://codereview.chromium.org/2196933002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_tooltip_manager_unittest.cc:39:
std::unique_ptr<views::Widget> CreateTestWidget() {
On 2016/08/01 16:58:03, James Cook wrote:
> Odd that AshTestBase::CreateTestWidget doesn't work. It's gotta be something
> about the container init. <shrug> I'm fine with this as-is.

Acknowledged. I can look separately.

[msw, 2016-08-01 17:25:51]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-01 17:25:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2196933002/#ps60001
(title: "Remove unused include.")

[commit-bot: I haz the power, 2016-08-01 17:26:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 18:08:19]

Description was changed from

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org
==========

to

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-01 18:08:20]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-01 18:11:18]

Description was changed from

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org
==========

to

==========
mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG=629255
TEST=automated
R=jamescook@chromium.org

Committed: https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6
Cr-Commit-Position: refs/heads/master@{#408998}
==========

[commit-bot: I haz the power, 2016-08-01 18:11:19]

Patchset 2 (id:??) landed as
https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6
Cr-Commit-Position: refs/heads/master@{#408998}