Make ash::DisplayMode more like ui::DisplayMode

Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
Committed: https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e
Cr-Commit-Position: refs/heads/master@{#410166}

[rjkroege, 2016-07-30 00:38:43]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 00:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 00:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:55:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjkroege, 2016-08-01 23:51:12]

Description was changed from

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
==========

to

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[rjkroege, 2016-08-01 23:51:54]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 23:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 00:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 00:03:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjkroege, 2016-08-02 15:44:20]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 15:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 16:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 16:36:01]

Dry run: This issue passed the CQ dry run.

[rjkroege, 2016-08-02 16:40:03]

rjkroege@chromium.org changed reviewers:
+ oshima@chromium.org

[rjkroege, 2016-08-02 16:40:04]

PTAL. First step. Change to unique_ptr in a next CL.

[oshima, 2016-08-02 19:44:58]

https://codereview.chromium.org/2196923002/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_commands_aura.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_commands_aura.cc:48: return false;
move this outside of if?

https://codereview.chromium.org/2196923002/diff/40001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/common/display/disp...
ash/common/display/display_info.h:55: // void setNative(bool native) { native_ =
native; }
looks like you already figured out?

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.h (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.h:21: class DisplayInfo;
nit: remove this?

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_man...
ash/display/display_manager.cc:1173: /* native */ true, dm->ui_scale(),
dm->device_scale_factor()));
nit:

true /* native */

is what I've been using and I believe it's a bit more common.
You may leave it if you prefer this way though.

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_chromeos.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_chromeos.cc:323: gfx::Size size;
size(info.display_mode-> .... ) ?

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:152: //
interlaced?
I guess this is used to select the actual mode, which has those information?

https://codereview.chromium.org/2196923002/diff/40001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/native/egl_native_x11.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/native/egl_native_x11.cc:28: return
static_cast<EGLImageKHR>(nullptr);
unrelated changes?

[rjkroege, 2016-08-04 00:12:05]

ptal

https://codereview.chromium.org/2196923002/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_commands_aura.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_commands_aura.cc:48: return false;
On 2016/08/02 19:44:57, oshima wrote:
> move this outside of if?

Done.

https://codereview.chromium.org/2196923002/diff/40001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/common/display/disp...
ash/common/display/display_info.h:55: // void setNative(bool native) { native_ =
native; }
On 2016/08/02 19:44:57, oshima wrote:
> looks like you already figured out?

true. :-) Removed.

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_cha...
File ash/display/display_change_observer_chromeos.h (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_cha...
ash/display/display_change_observer_chromeos.h:21: class DisplayInfo;
On 2016/08/02 19:44:57, oshima wrote:
> nit: remove this?

Done.

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/ash/display/display_man...
ash/display/display_manager.cc:1173: /* native */ true, dm->ui_scale(),
dm->device_scale_factor()));
On 2016/08/02 19:44:57, oshima wrote:
> nit:
> 
> true /* native */
> 
> is what I've been using and I believe it's a bit more common.
> You may leave it if you prefer this way though.

Done.  (Hopefully everywhere.)

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_chromeos.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_chromeos.cc:323: gfx::Size size;
On 2016/08/02 19:44:57, oshima wrote:
> size(info.display_mode-> .... ) ?

Done.

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2196923002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:152: //
interlaced?
On 2016/08/02 19:44:57, oshima wrote:
> I guess this is used to select the actual mode, which has those information?

Done.

https://codereview.chromium.org/2196923002/diff/40001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/native/egl_native_x11.cc (right):

https://codereview.chromium.org/2196923002/diff/40001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/native/egl_native_x11.cc:28: return
static_cast<EGLImageKHR>(nullptr);
On 2016/08/02 19:44:57, oshima wrote:
> unrelated changes?

yes. pulled out into different CL.

[oshima, 2016-08-04 17:54:01]

lgtm

https://codereview.chromium.org/2196923002/diff/60001/ash/accelerators/accele...
File ash/accelerators/accelerator_commands_aura.cc (right):

https://codereview.chromium.org/2196923002/diff/60001/ash/accelerators/accele...
ash/accelerators/accelerator_commands_aura.cc:51: return false;
optional nit:

 return mode ? .. : false;

[rjkroege, 2016-08-04 20:29:24]

rjkroege@chromium.org changed reviewers:
+ sky@chromium.org

[rjkroege, 2016-08-04 20:29:25]

+sky for OWNERS in chrome/browser/

[sky, 2016-08-04 22:26:03]

LGTM

[rjkroege, 2016-08-05 18:56:43]

Description was changed from

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
==========

[rjkroege, 2016-08-05 18:56:43]

rjkroege@chromium.org changed reviewers:
+ stevenjb@chromium.org

[rjkroege, 2016-08-05 18:58:19]

+stevenjb for final OWNERs for chrome/browser/ui/webui/options

[stevenjb, 2016-08-05 19:53:52]

c/b/extensions, c/b/ui/webui lgtm

[rjkroege, 2016-08-05 20:37:44]

The CQ bit was checked by rjkroege@chromium.org

[commit-bot: I haz the power, 2016-08-05 20:38:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 21:20:20]

Description was changed from

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
==========

to

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
==========

[commit-bot: I haz the power, 2016-08-05 21:20:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 21:21:51]

Description was changed from

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778
==========

to

==========
Make ash::DisplayMode more like ui::DisplayMode

As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo,
make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL
can remove ash::DisplayMode.

BUG=626778

Committed: https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e
Cr-Commit-Position: refs/heads/master@{#410166}
==========

[commit-bot: I haz the power, 2016-08-05 21:21:53]

Patchset 4 (id:??) landed as
https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e
Cr-Commit-Position: refs/heads/master@{#410166}