Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2196903002: Use bool instead of FX_BOOL as return values in CPVT_GenerateAP. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use bool instead of FX_BOOL as return values in CPVT_GenerateAP. Committed: https://pdfium.googlesource.com/pdfium/+/9c987e9d233c855951db2611433b9cbc4f1b648f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use bool instead of FX_BOOL as return values in CPVT_GenerateAP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M core/fpdfdoc/cpvt_generateap.h View 1 chunk +7 lines, -7 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 6 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jaepark
4 years, 4 months ago (2016-07-29 23:54:58 UTC) #2
Lei Zhang
https://codereview.chromium.org/2196903002/diff/1/core/fpdfdoc/cpvt_generateap.cpp File core/fpdfdoc/cpvt_generateap.cpp (right): https://codereview.chromium.org/2196903002/diff/1/core/fpdfdoc/cpvt_generateap.cpp#newcode30 core/fpdfdoc/cpvt_generateap.cpp:30: return FALSE; return true/false
4 years, 4 months ago (2016-07-30 00:38:20 UTC) #3
jaepark
https://codereview.chromium.org/2196903002/diff/1/core/fpdfdoc/cpvt_generateap.cpp File core/fpdfdoc/cpvt_generateap.cpp (right): https://codereview.chromium.org/2196903002/diff/1/core/fpdfdoc/cpvt_generateap.cpp#newcode30 core/fpdfdoc/cpvt_generateap.cpp:30: return FALSE; On 2016/07/30 00:38:20, Lei Zhang wrote: > ...
4 years, 4 months ago (2016-07-30 00:47:30 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-07-30 00:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196903002/20001
4 years, 4 months ago (2016-07-30 01:17:30 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 01:17:49 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9c987e9d233c855951db2611433b9cbc4f1b...

Powered by Google App Engine
This is Rietveld 408576698