|
|
Created:
4 years, 4 months ago by scheib Modified:
4 years, 4 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionbluetooth: Add optional 'name' support to MockBluetoothDevice.
The mock previously always provided a name value. However,
the base supports the name not existing, and tests need
this mock to be able to return nullopt as well.
Split out from this following patch:
Web Bluetooth can filter by empty device names, doesn't leak MACs.
http://crrev.com/2014473002
BUG=586438
Refactor TBR for proximity test:
TBR=msarda@chromium.org
Committed: https://crrev.com/16585eebf8d69b201c64127acf3f47300d1013e5
Cr-Commit-Position: refs/heads/master@{#409298}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 39 (33 generated)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== bluetooth: Add optional name support to MockBluetoothDevice. The mock previously always provided a name value. BUG=586438 ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Immediately needed for: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 Web Bluetooth updated BUG=586438 ==========
scheib@chromium.org changed reviewers: + ortuno@chromium.org
Description was changed from ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Immediately needed for: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 Web Bluetooth updated BUG=586438 ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 Web Bluetooth updated BUG=586438 ==========
Description was changed from ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 Web Bluetooth updated BUG=586438 ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ping ortuno
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
PTAL ortuno
lgtm
The CQ bit was unchecked by scheib@chromium.org
The CQ bit was checked by scheib@chromium.org
The CQ bit was unchecked by scheib@chromium.org
Description was changed from ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org ==========
scheib@chromium.org changed reviewers: + msarda@chromium.org
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org ========== to ========== bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org Committed: https://crrev.com/16585eebf8d69b201c64127acf3f47300d1013e5 Cr-Commit-Position: refs/heads/master@{#409298} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/16585eebf8d69b201c64127acf3f47300d1013e5 Cr-Commit-Position: refs/heads/master@{#409298} |