Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2196883002: bluetooth: Add optional 'name' support to MockBluetoothDevice. (Closed)

Created:
4 years, 4 months ago by scheib
Modified:
4 years, 4 months ago
Reviewers:
ortuno, msarda
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add optional 'name' support to MockBluetoothDevice. The mock previously always provided a name value. However, the base supports the name not existing, and tests need this mock to be able to return nullopt as well. Split out from this following patch: Web Bluetooth can filter by empty device names, doesn't leak MACs. http://crrev.com/2014473002 BUG=586438 Refactor TBR for proximity test: TBR=msarda@chromium.org Committed: https://crrev.com/16585eebf8d69b201c64127acf3f47300d1013e5 Cr-Commit-Position: refs/heads/master@{#409298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 3 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 39 (33 generated)
scheib
ping ortuno
4 years, 4 months ago (2016-08-02 00:57:37 UTC) #15
scheib
PTAL ortuno
4 years, 4 months ago (2016-08-02 18:59:26 UTC) #27
ortuno
lgtm
4 years, 4 months ago (2016-08-02 19:11:42 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196883002/60001
4 years, 4 months ago (2016-08-02 20:11:45 UTC) #35
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 4 months ago (2016-08-02 20:16:36 UTC) #37
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 20:18:07 UTC) #39
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16585eebf8d69b201c64127acf3f47300d1013e5
Cr-Commit-Position: refs/heads/master@{#409298}

Powered by Google App Engine
This is Rietveld 408576698