Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: test/whitespace/functions.unit

Issue 2196863002: Format parameter lists with trailing commas like argument lists. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« lib/src/source_visitor.dart ('K') | « test/comments/functions.unit ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 40 columns | 1 40 columns |
2 >>> external 2 >>> external
3 external 3 external
4 void 4 void
5 printToConsole(line); 5 printToConsole(line);
6 <<< 6 <<<
7 external void printToConsole(line); 7 external void printToConsole(line);
8 >>> nested functions 8 >>> nested functions
9 x(){y(){z(){}}} 9 x(){y(){z(){}}}
10 <<< 10 <<<
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 main() async* { 70 main() async* {
71 var lambda = () async* {}; 71 var lambda = () async* {};
72 } 72 }
73 >>> sync* functions 73 >>> sync* functions
74 main()sync *{var lambda = ()sync *{};} 74 main()sync *{var lambda = ()sync *{};}
75 <<< 75 <<<
76 main() sync* { 76 main() sync* {
77 var lambda = () sync* {}; 77 var lambda = () sync* {};
78 } 78 }
79 >>> trailing comma in single parameter list 79 >>> trailing comma in single parameter list
80 function(argument , ) {} 80 function(parameter , ) {;}
81 <<< 81 <<<
82 function(argument,) {} 82 function(
83 parameter,
84 ) {
85 ;
86 }
83 >>> trailing comma in parameter list 87 >>> trailing comma in parameter list
84 function(argument,argument , ) {} 88 function(parameter,parameter , ) {;}
85 <<< 89 <<<
86 function(argument, argument,) {} 90 function(
91 parameter,
92 parameter,
93 ) {
94 ;
95 }
96 >>> trailing comma in all optional parameter list
97 function([parameter,parameter , ]) {;}
98 <<<
99 function([
100 parameter,
101 parameter,
102 ]) {
103 ;
104 }
105 >>> trailing comma in all named parameter list
106 function({parameter,parameter , }) {;}
107 <<<
108 function({
109 parameter,
110 parameter,
111 }) {
112 ;
113 }
114 >>> trailing comma in mixed optional parameter list
115 function(parameter,[parameter,parameter , ]) {;}
116 <<<
117 function(
118 parameter, [
119 parameter,
120 parameter,
121 ]) {
122 ;
123 }
124 >>> trailing comma in mixed named parameter list
125 function(parameter,{parameter,parameter , }) {;}
126 <<<
127 function(
128 parameter, {
129 parameter,
130 parameter,
131 }) {
132 ;
133 }
134 >>> trailing comma with => function containing split
135 function(parameter,parameter,) => veryLongBodyThatWraps(argument, argument, argu ment, argument);
136 <<<
137 function(
138 parameter,
139 parameter,
140 ) =>
141 veryLongBodyThatWraps(argument,
142 argument, argument, argument);
143 >>> trailing comma with wrap at =>
144 function(parameter,parameter,) /* comment */ => "a very very long string";
145 <<<
146 function(
147 parameter,
148 parameter,
149 ) /* comment */ =>
150 "a very very long string";
151 >>> trailing comma function nested in expression
152 main() {
153 someVeryLongFunction(argument, argument, (parameter, parameter,) {;});
154 }
155 <<< (this looks weird, but it should rare and at least we test it)
156 main() {
157 someVeryLongFunction(
158 argument, argument, (
159 parameter,
160 parameter,
161 ) {
162 ;
163 });
164 }
OLDNEW
« lib/src/source_visitor.dart ('K') | « test/comments/functions.unit ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698