Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: git_cl.py

Issue 2196843002: remove luci hacks (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | luci_hacks/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 1e2261c131943f0320a35196257102011ceadfda..7199f260d6a43e5e69862d610f9ea40549c28194 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -41,7 +41,6 @@ from third_party import colorama
from third_party import httplib2
from third_party import upload
import auth
-from luci_hacks import trigger_luci_job as luci_trigger
import clang_format
import commit_queue
import dart_format
@@ -281,19 +280,6 @@ def _buildbucket_retry(operation_name, http, *args, **kwargs):
assert False, 'unreachable'
-def trigger_luci_job(changelist, masters, options):
- """Send a job to run on LUCI."""
- issue_props = changelist.GetIssueProperties()
- issue = changelist.GetIssue()
- patchset = changelist.GetMostRecentPatchset()
- for builders_and_tests in sorted(masters.itervalues()):
- # TODO(hinoka et al): add support for other properties.
- # Currently, this completely ignores testfilter and other properties.
- for builder in sorted(builders_and_tests):
- luci_trigger.trigger(
- builder, 'HEAD', issue, patchset, issue_props['project'])
-
-
def trigger_try_jobs(auth_config, changelist, options, masters, category):
rietveld_url = settings.GetDefaultServerUrl()
rietveld_host = urlparse.urlparse(rietveld_url).hostname
@@ -4450,7 +4436,6 @@ def CMDtry(parser, args):
group.add_option(
"-m", "--master", default='',
help=("Specify a try master where to run the tries."))
- group.add_option( "--luci", action='store_true')
group.add_option(
"-r", "--revision",
help="Revision to use for the try job; default: the "
@@ -4612,9 +4597,7 @@ def CMDtry(parser, args):
'\nWARNING Mismatch between local config and server. Did a previous '
'upload fail?\ngit-cl try always uses latest patchset from rietveld. '
'Continuing using\npatchset %s.\n' % patchset)
- if options.luci:
- trigger_luci_job(cl, masters, options)
- elif not options.use_rietveld:
+ if not options.use_rietveld:
try:
trigger_try_jobs(auth_config, cl, options, masters, 'git_cl_try')
except BuildbucketResponseException as ex:
« no previous file with comments | « no previous file | luci_hacks/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698